From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] pull: clarify the large && { ... } form
Date: Fri, 14 Jun 2013 11:09:50 +0200 [thread overview]
Message-ID: <vpqr4g5kqht.fsf@anie.imag.fr> (raw)
In-Reply-To: <1371200178-9927-3-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Fri, 14 Jun 2013 14:26:18 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> -test true = "$rebase" && {
> +if test true = "$rebase"; then
Use a newline, not a ';'.
See CodingGuideLines:
- Do not write control structures on a single line with semicolon.
"then" should be on the next line for if statements, and "do"
should be on the next line for "while" and "for".
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-06-14 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 8:56 [PATCH 0/2] Rebasing pull with autostash Ramkumar Ramachandra
2013-06-14 8:56 ` [PATCH 1/2] pull: respect rebase.autostash Ramkumar Ramachandra
2013-06-14 9:13 ` Matthieu Moy
2013-06-14 10:41 ` Ramkumar Ramachandra
2013-06-14 11:59 ` Phil Hord
2013-06-14 18:26 ` Junio C Hamano
2013-06-14 12:12 ` Phil Hord
2013-06-14 12:21 ` Phil Hord
2013-06-14 12:29 ` John Keeping
2013-06-14 12:41 ` Phil Hord
2013-06-14 12:46 ` Ramkumar Ramachandra
2013-06-14 8:56 ` [PATCH 2/2] pull: clarify the large && { ... } form Ramkumar Ramachandra
2013-06-14 9:09 ` Matthieu Moy [this message]
2013-06-14 10:47 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqr4g5kqht.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.