From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Manlio Perillo <manlio.perillo@gmail.com>
Subject: Re: [RFC/PATCH] git-completion.bash: remove bashism to fix ZSH compatibility
Date: Mon, 11 Mar 2013 17:47:40 +0100 [thread overview]
Message-ID: <vpqtxohubmb.fsf@grenoble-inp.fr> (raw)
In-Reply-To: <7vobepany3.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 11 Mar 2013 09:41:40 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> So here is an updated based on your patch.
Perfect, thanks.
> The correct thing to do in the longer term may be to stop dot-sourcing
> the source meant for bash into zsh, but this patch should suffice as
> a band-aid in the meantime.
I disagree with this particular part though. I think using the same code
for bash and zsh makes sense, and it implies restricting to the common
subset. I don't consider it "band-aid", but "nice code factoring" ;-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-03-11 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 12:21 [RFC/PATCH] git-completion.bash: remove bashism to fix ZSH compatibility Matthieu Moy
2013-03-11 16:17 ` Junio C Hamano
2013-03-11 16:41 ` Junio C Hamano
2013-03-11 16:47 ` Matthieu Moy [this message]
2013-03-11 17:01 ` Junio C Hamano
2013-03-11 17:12 ` Manlio Perillo
2013-03-11 17:09 ` Manlio Perillo
2013-03-11 17:23 ` Junio C Hamano
2013-03-11 17:48 ` Matthieu Moy
2013-03-11 18:09 ` Junio C Hamano
2013-03-11 18:19 ` Paul Smith
2013-03-11 19:09 ` Manlio Perillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqtxohubmb.fsf@grenoble-inp.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=manlio.perillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.