From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Joey Hess <id@joeyh.name>
Cc: git@vger.kernel.org, Paul Tan <pyokagan@gmail.com>
Subject: Re: git pull --upload-pack reversion in git 2.5.0
Date: Thu, 30 Jul 2015 19:17:05 +0200 [thread overview]
Message-ID: <vpqvbd1k1ke.fsf@anie.imag.fr> (raw)
In-Reply-To: <20150730154523.GA17002@kitenet.net> (Joey Hess's message of "Thu, 30 Jul 2015 11:45:23 -0400")
Joey Hess <id@joeyh.name> writes:
> In git 2.1.4, I can run: git pull --upload-pack 'echo --foo'
>
> This also seems to work in 2.4.6, but in 2.5.0, the option parser
> does something weird, apparently looking inside the quoted parameter
> and parsing parameters in there:
>
> error: unknown option `foo'
> usage: git fetch [<options>] [<repository> [<refspec>...]]
This bisects down to:
commit e3b601da2af53cbb9a63e59113d524a8d946ea12 (junio/pt/pull-optparse)
Author: Paul Tan <pyokagan@gmail.com>
Date: Tue Jun 2 22:22:53 2015 +0800
pull: use git-rev-parse --parseopt for option parsing
To enable unambiguous parsing of abbreviated options, bundled short
options, separate form options and to provide consistent usage help, use
git-rev-parse --parseopt for option parsing. With this, simplify the
option parsing code.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
=> Cc-ing Paul.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-07-30 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 15:45 git pull --upload-pack reversion in git 2.5.0 Joey Hess
2015-07-30 17:17 ` Matthieu Moy [this message]
2015-07-30 18:31 ` Joey Hess
2015-07-30 18:41 ` Junio C Hamano
2015-07-30 20:40 ` [PATCH] pull.sh: quote $upload_pack when passing it to git-fetch Matthieu Moy
2015-07-30 21:13 ` Junio C Hamano
2015-07-31 11:01 ` Paul Tan
2015-07-31 17:54 ` git pull --upload-pack reversion in git 2.5.0 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbd1k1ke.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=id@joeyh.name \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.