From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org,
remi lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
louis--alexandre stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
remi galan-alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
guillaume pages <guillaume.pages@ensimag.grenoble-inp.fr>,
chriscool@tuxfamily.org, thomasxnguy@gmail.com,
valentinduperray@gmail.com
Subject: Re: [PATCH v2 2/7] bisect: replace hardcoded "bad|good" by variables
Date: Mon, 22 Jun 2015 15:47:34 +0200 [thread overview]
Message-ID: <vpqvbefc0sp.fsf@anie.imag.fr> (raw)
In-Reply-To: <134997869.703022.1434976943783.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Antoine Delaite's message of "Mon, 22 Jun 2015 14:42:23 +0200 (CEST)")
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
>
>>Being an acceptable ref name is a constraint you have to check (Junio
>>already mentionned check-ref-format). I think quoting variables makes
>>sense too
>
> I don't get how 'git check-ref-format' works exactly. It says it needs
> at least one slash in the ref name. So it would not be good for bisect
> terms.
At some point, refs/bisect/$good and refs/bisect/$bad-$sha1 will become
refs, so you should check refs/bisect/$good and refs/bisect/$bad with
check-ref-format (I think the -$sha1 suffix will be accepted by
construction).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-22 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 16:24 [PATCH v2 1/7] bisect : correction of typo Antoine Delaite
2015-06-10 16:24 ` [PATCH v2 2/7] bisect: replace hardcoded "bad|good" by variables Antoine Delaite
2015-06-11 15:27 ` Matthieu Moy
2015-06-22 12:42 ` Antoine Delaite
2015-06-22 13:47 ` Matthieu Moy [this message]
2015-06-10 16:24 ` [PATCH v2 3/7] bisect: simplify the addition of new bisect terms Antoine Delaite
2015-06-10 16:24 ` [PATCH v2 4/7] bisect: add the terms old/new Antoine Delaite
2015-06-10 21:03 ` Junio C Hamano
2015-06-14 11:51 ` Louis-Alexandre Stuber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbefc0sp.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=thomasxnguy@gmail.com \
--cc=valentinduperray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.