From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 5/6] config: add `git_die_config()` to the config-set API
Date: Fri, 25 Jul 2014 16:03:11 +0200 [thread overview]
Message-ID: <vpqvbqlo7s0.fsf@anie.imag.fr> (raw)
In-Reply-To: <1406293095-15920-6-git-send-email-tanayabh@gmail.com> (Tanay Abhra's message of "Fri, 25 Jul 2014 05:58:14 -0700")
Tanay Abhra <tanayabh@gmail.com> writes:
> --- a/config.c
> +++ b/config.c
> @@ -1403,11 +1403,12 @@ const struct string_list *git_configset_get_value_multi(struct config_set *cs, c
>
> int git_configset_get_string_const(struct config_set *cs, const char *key, const char **dest)
> {
> - const char *value;
> - if (!git_configset_get_value(cs, key, &value))
> - return git_config_string(dest, key, value);
> - else
> - return 1;
> + int ret;
> + char *value;
> + ret = git_configset_get_string(cs, key, &value);
> + if (ret <= 0)
> + *dest = (const char*)value;
> + return ret;
> }
Isn't this a fixup meant for another series?
> int git_configset_get_string(struct config_set *cs, const char *key, char **dest)
> @@ -1418,8 +1419,7 @@ int git_configset_get_string(struct config_set *cs, const char *key, char **dest
> return config_error_nonbool(key);
> *dest = xstrdup(value);
> return 0;
> - }
> - else
> + } else
> return 1;
Useless churn.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-25 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 12:58 [PATCH v2 0/6] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 1/6] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 2/6] add line number and file name info to `config_set` Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 3/6] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-25 13:58 ` Matthieu Moy
2014-07-25 14:07 ` Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 4/6] add a test for semantic errors in config files Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 5/6] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-25 14:03 ` Matthieu Moy [this message]
2014-07-25 14:12 ` Tanay Abhra
2014-07-25 17:29 ` Junio C Hamano
2014-07-25 12:58 ` [PATCH v2 6/6] Add tests for `git_config_get_string()` Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbqlo7s0.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.