From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Tanay Abhra <tanayabh@gmail.com>, Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v5 2/2] test-config: Add tests for the config_set API
Date: Mon, 07 Jul 2014 09:11:37 +0200 [thread overview]
Message-ID: <vpqvbr91w46.fsf@anie.imag.fr> (raw)
In-Reply-To: <CALkWK0n9MWux3tA02n-hDvPjXt3Q1RCVd+x8tJV9ABjndaGQCQ@mail.gmail.com> (Ramkumar Ramachandra's message of "Sun, 6 Jul 2014 19:24:26 -0400")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> A couple of quick nits.
>
> Tanay Abhra wrote:
>> +test_expect_success 'clear default config' '
>> + rm -f .git/config
>> +'
>
> Unnecessary; a fresh temporary directory is created for each test run.
Hmm, fresh, but not empty.
Anyway, the next test does a cat > on this file, so it will erase its
content, so the "rm -f" is actually not needed.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2014-07-07 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 7:19 [PATCH v5 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-06 7:19 ` [PATCH v5 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-06 11:15 ` Ramsay Jones
2014-07-06 17:45 ` Matthieu Moy
2014-07-06 7:19 ` [PATCH v5 2/2] test-config: Add tests for the config_set API Tanay Abhra
2014-07-06 18:33 ` Matthieu Moy
2014-07-06 19:57 ` Matthieu Moy
2014-07-06 23:24 ` Ramkumar Ramachandra
2014-07-07 7:11 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbr91w46.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.