From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v7 05/12] for-each-ref: introduce new structures for better organisation Date: Thu, 11 Jun 2015 19:41:41 +0200 Message-ID: References: <5579B253.4020804@gmail.com> <1434039003-10928-1-git-send-email-karthik.188@gmail.com> <1434039003-10928-5-git-send-email-karthik.188@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, christian.couder@gmail.com To: Karthik Nayak X-From: git-owner@vger.kernel.org Thu Jun 11 19:42:23 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z36Ue-0002ll-Nt for gcvg-git-2@plane.gmane.org; Thu, 11 Jun 2015 19:42:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755236AbbFKRlt (ORCPT ); Thu, 11 Jun 2015 13:41:49 -0400 Received: from mx1.imag.fr ([129.88.30.5]:51216 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754683AbbFKRlq (ORCPT ); Thu, 11 Jun 2015 13:41:46 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t5BHfd1n002744 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Jun 2015 19:41:39 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t5BHffTA016836; Thu, 11 Jun 2015 19:41:41 +0200 In-Reply-To: <1434039003-10928-5-git-send-email-karthik.188@gmail.com> (Karthik Nayak's message of "Thu, 11 Jun 2015 21:39:56 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Thu, 11 Jun 2015 19:41:40 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t5BHfd1n002744 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1434649302.32003@YBGk6n5KunCExLjkccjhVQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karthik Nayak writes: > +struct ref_filter_cbdata { > + struct ref_array array; > + struct ref_filter filter; > +}; I didn't notice this at first, but why introduce the structure like this when you are going to turn it into pointers later in PATCH 7: Karthik Nayak writes: > --- a/ref-filter.h > +++ b/ref-filter.h > @@ -42,12 +45,17 @@ struct ref_filter { > }; > > struct ref_filter_cbdata { > - struct ref_array array; > - struct ref_filter filter; > + struct ref_array *array; > + struct ref_filter *filter; > }; -- Matthieu Moy http://www-verimag.imag.fr/~moy/