From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org,
Remi Galan <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH v5 2/3] t4150-am: refactor am -3 tests
Date: Mon, 08 Jun 2015 13:36:11 +0200 [thread overview]
Message-ID: <vpqwpzectzo.fsf@anie.imag.fr> (raw)
In-Reply-To: <1433460284-20240-2-git-send-email-remi.lespinet@ensimag.grenoble-inp.fr> (Remi Lespinet's message of "Fri, 5 Jun 2015 01:24:43 +0200")
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr> writes:
> +test_expect_success 'setup am -3' '
> + rm -fr .git/rebase-apply &&
I don't think you need this 'rm -fr' since you're going to repeat it at
the beginning of individual tests. But it doesn't harm to keep it just
in case.
With or without this 'rm -fr', the series looks good to me. Thanks.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-08 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 23:24 [PATCH v5 1/3] git-am.sh: fix initialization of the threeway variable Remi Lespinet
2015-06-04 23:24 ` [PATCH v5 2/3] t4150-am: refactor am -3 tests Remi Lespinet
2015-06-08 11:36 ` Matthieu Moy [this message]
2015-06-04 23:24 ` [PATCH v5 3/3] git-am: add am.threeWay config variable Remi Lespinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqwpzectzo.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.