From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Paul Tan <pyokagan@gmail.com>, Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v4 4/4] t0302: test credential-store support for XDG_CONFIG_HOME
Date: Thu, 19 Mar 2015 14:35:49 +0100 [thread overview]
Message-ID: <vpqy4mtrtxm.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAPig+cTaQAnWoz7=v9tOPZoeE3LTV+H6KD_tAzmOXi3Tjay_WA@mail.gmail.com> (Eric Sunshine's message of "Wed, 18 Mar 2015 17:15:10 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> I also tend to favor adding "failure" tests which are flipped to
> "success" when appropriate, however, as this is an entirely new
> feature, this approach may be unsuitable (and perhaps overkill).
I can buy the "overkill", but not unsuitable. Even for new features, the
tests should fail before and pass after. Otherwise, the tests are not
testing the feature. Actually, this is a strong principle in test-driven
development: don't write code unless you have a failing test.
But I was just thinking out loudly, certainly not requesting a change.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-03-19 13:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 7:04 [PATCH v4 1/4] git-credential-store: support multiple credential files Paul Tan
2015-03-18 7:04 ` [PATCH v4 2/4] git-credential-store: support XDG_CONFIG_HOME Paul Tan
2015-03-18 7:04 ` [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence Paul Tan
2015-03-18 16:23 ` Matthieu Moy
2015-03-21 5:59 ` Paul Tan
2015-03-18 7:04 ` [PATCH v4 4/4] t0302: test credential-store support for XDG_CONFIG_HOME Paul Tan
2015-03-18 16:41 ` Matthieu Moy
2015-03-18 21:15 ` Eric Sunshine
2015-03-19 13:35 ` Matthieu Moy [this message]
2015-03-21 10:01 ` Paul Tan
2015-03-18 19:26 ` Eric Sunshine
2015-03-19 21:53 ` Eric Sunshine
2015-03-21 5:46 ` Paul Tan
2015-03-23 1:56 ` Eric Sunshine
2015-03-18 16:17 ` [PATCH v4 1/4] git-credential-store: support multiple credential files Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqy4mtrtxm.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=pyokagan@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.