From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API Date: Mon, 21 Jul 2014 15:45:56 +0200 Message-ID: References: <1405941145-12120-1-git-send-email-tanayabh@gmail.com> <53CD1280.1080107@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, Ramkumar Ramachandra To: Tanay Abhra X-From: git-owner@vger.kernel.org Mon Jul 21 15:46:29 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X9Dv1-000544-JK for gcvg-git-2@plane.gmane.org; Mon, 21 Jul 2014 15:46:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932418AbaGUNqL (ORCPT ); Mon, 21 Jul 2014 09:46:11 -0400 Received: from mx1.imag.fr ([129.88.30.5]:39386 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932419AbaGUNqJ (ORCPT ); Mon, 21 Jul 2014 09:46:09 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id s6LDjsrZ008386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Jul 2014 15:45:54 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id s6LDjuRj025331; Mon, 21 Jul 2014 15:45:56 +0200 In-Reply-To: <53CD1280.1080107@gmail.com> (Tanay Abhra's message of "Mon, 21 Jul 2014 18:45:44 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Mon, 21 Jul 2014 15:45:54 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: s6LDjsrZ008386 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1406555157.04093@XgZlXt50HliRoWHH1eamFA Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Tanay Abhra writes: > On 7/21/2014 6:21 PM, Matthieu Moy wrote: >> 2) Add a by-address parameter to git_configset_get_value that allows the >> user to get the file and line information. In your previous patch, >> that would mean returning a pointer to the corresponding struct >> key_source. > > Will this extra complexity be good for "git_configset_get_value"? > Instead can we provide a function like die_config(char *key) > which prints > die("bad config file line %d in %s", linenr, filename);? Where would you call this function, and where would you take linenr and filename? -- Matthieu Moy http://www-verimag.imag.fr/~moy/