From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org, Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 4/5] t/t1304: set the mask ACL that is checked in check_perms_and_acl
Date: Mon, 15 Mar 2010 18:37:27 +0100 [thread overview]
Message-ID: <vpqy6ht5vvs.fsf@bauges.imag.fr> (raw)
In-Reply-To: <YowxgPZqaOkg2MZzY1CxLzeL4DIwxt_o3RKS9xen-cewKbECZA7OIb7mUaY2TbsVR_rHE5GTeU0@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Mon\, 15 Mar 2010 12\:14\:36 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> test_expect_success 'Setup test repo' '
> setfacl -m d:u::rwx,d:g::---,d:o:---,d:m:rwx $dirs_to_set &&
> + setfacl -m m:rwx $dirs_to_set &&
The patch sounds right, but I don't understand the commit message. You
set m:rwx, and check_perms_and_acl expects mask::r--, so it's not
exactly what check_perms_and_acl checks.
My understanding is that you set the mask here to enforce the validity
of the ACL, but then you may want to just squash this into [PATCH 2/5].
But again, that's bikeshedding, the patch serie looks right to me.
Sorry for not making the test right myself ;-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-03-15 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 17:14 [PATCH 0/5] tweak t1304 ACL tests so they work on Solaris Brandon Casey
2010-03-15 17:14 ` [PATCH 1/5] t/t1304: avoid -d option to setfacl Brandon Casey
2010-03-15 17:14 ` [PATCH 2/5] t/t1304: set the Default ACL base entries Brandon Casey
2010-03-15 17:14 ` [PATCH 3/5] t/t1304: use 'test -r' to test readability rather than looking at mode bits Brandon Casey
2010-03-15 17:33 ` Matthieu Moy
2010-03-15 17:51 ` Brandon Casey
2010-03-15 17:14 ` [PATCH 4/5] t/t1304: set the mask ACL that is checked in check_perms_and_acl Brandon Casey
2010-03-15 17:37 ` Matthieu Moy [this message]
2010-03-15 18:17 ` Brandon Casey
2010-03-15 18:35 ` [PATCH 4/5 v2] t/t1304: set the ACL effective rights mask Brandon Casey
2010-03-15 18:53 ` Matthieu Moy
2010-03-15 17:14 ` [PATCH 5/5] t/t1304: make a second colon optional in the mask ACL check Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqy6ht5vvs.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.