From: Alberto Garcia <berto@igalia.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Thomas Huth <thuth@redhat.com>,
"R . Nageswara Sastry" <nasastry@in.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] qcow2: Prevent allocating L2 tables at offset 0
Date: Fri, 03 Nov 2017 10:56:13 +0100 [thread overview]
Message-ID: <w51a803bs8y.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <8403f7a8-2ca1-d7b0-34d4-5e027112d005@redhat.com>
On Thu 02 Nov 2017 06:31:18 PM CET, Max Reitz wrote:
>> + /* If we're allocating the table at offset 0 then something is wrong */
>> + if (l2_offset == 0) {
>> + qcow2_signal_corruption(bs, true, -1, -1, "Preventing invalid "
>> + "allocation of L2 table at offset 0");
>> + return -EIO;
>
> The other error paths in this function use a goto fail. It doesn't
> make a functional difference, but not doing it here looks a bit weird.
Oh, you're right. I'll fix it.
Berto
next prev parent reply other threads:[~2017-11-03 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 15:42 [Qemu-devel] [PATCH 0/4] Misc qcow2 corruption checks Alberto Garcia
2017-11-01 15:42 ` [Qemu-devel] [PATCH 1/4] qcow2: Prevent allocating refcount blocks at offset 0 Alberto Garcia
2017-11-02 17:28 ` Max Reitz
2017-11-03 9:04 ` Alberto Garcia
2017-11-01 15:42 ` [Qemu-devel] [PATCH 2/4] qcow2: Prevent allocating L2 tables " Alberto Garcia
2017-11-02 17:31 ` Max Reitz
2017-11-03 9:56 ` Alberto Garcia [this message]
2017-11-01 15:42 ` [Qemu-devel] [PATCH 3/4] qcow2: Don't open images with header.refcount_table_clusters == 0 Alberto Garcia
2017-11-02 17:41 ` Max Reitz
2017-11-01 15:42 ` [Qemu-devel] [PATCH 4/4] qcow2: Add iotest for an empty refcount table Alberto Garcia
2017-11-02 17:43 ` Max Reitz
2017-11-02 17:24 ` [Qemu-devel] [PATCH 0/4] Misc qcow2 corruption checks Max Reitz
2017-11-03 12:32 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51a803bs8y.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nasastry@in.ibm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.