From: Alberto Garcia <berto@igalia.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] I/O accounting overhaul
Date: Fri, 05 Jun 2015 15:55:46 +0200 [thread overview]
Message-ID: <w51a8we1cpp.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <556F0CC5.4040401@redhat.com>
On Wed 03 Jun 2015 04:18:45 PM CEST, Eric Blake wrote:
>> The accounting stats are stored in the BlockDriverState, but they're
>> actually from the device backed by the BDS, so they could probably be
>> moved there. For the interface we could extend BlockDeviceStats and
>> add the new fields, but query-blockstats works on BDS, so maybe we
>> need new API?
>
> We want stats per BDS (it would be nice to know how many reads are
> satisfied from the active layer, vs. how many are satisfied from the
> backing image, to know how stable and useful the backing image is).
> But we also want stats per BB (how many reads did the guest attempt,
> regardless of which BDS served the read). So any good solution needs
> to work from both views (whether by two API, or by one with a flag, is
> bike-shedding).
That's right. As I said my priority is the stats from the BB (i.e. what
the guest can see), but I agree that any solution has to consider that
we want to have both eventually.
Berto
next prev parent reply other threads:[~2015-06-05 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 13:40 [Qemu-devel] I/O accounting overhaul Alberto Garcia
2015-06-03 14:18 ` Eric Blake
2015-06-05 13:55 ` Alberto Garcia [this message]
2015-06-08 13:21 ` Stefan Hajnoczi
2015-06-10 11:41 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51a8we1cpp.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.