From: Alberto Garcia <berto@igalia.com>
To: wangliangzz@126.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, wangliangzz@126.com
Cc: pbonzini@redhat.com, stefanha@redhat.com,
silbe@linux.vnet.ibm.com, Wang Liang <wangliangzz@inspur.com>
Subject: Re: [PATCH] ratelimit: restrict the delay time to a non-negative value
Date: Tue, 20 Sep 2022 13:18:54 +0000 [thread overview]
Message-ID: <w51h712i3pd.fsf@igalia.com> (raw)
In-Reply-To: <20220920123350.205391-1-wangliangzz@126.com>
On Tue 20 Sep 2022 08:33:50 PM +08, wangliangzz@126.com wrote:
> From: Wang Liang <wangliangzz@inspur.com>
>
> The delay time should never be a negative value.
>
> - return limit->slice_end_time - now;
> + return MAX(limit->slice_end_time - now, 0);
How can this be negative? slice_end_time is guaranteed to be larger than
now:
if (limit->slice_end_time < now) {
/* Previous, possibly extended, time slice finished; reset the
* accounting. */
limit->slice_start_time = now;
limit->slice_end_time = now + limit->slice_ns;
limit->dispatched = 0;
}
Berto
next prev parent reply other threads:[~2022-09-20 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 12:33 [PATCH] ratelimit: restrict the delay time to a non-negative value wangliangzz
2022-09-20 13:18 ` Alberto Garcia [this message]
2022-09-21 1:47 ` Wang Liang
2022-09-21 4:53 ` Markus Armbruster
2022-09-21 6:26 ` Wang Liang
2022-09-21 8:17 ` Alberto Garcia
2022-09-23 7:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51h712i3pd.fsf@igalia.com \
--to=berto@igalia.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=wangliangzz@126.com \
--cc=wangliangzz@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.