From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E4BCA9ED4 for ; Mon, 4 Nov 2019 15:50:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55D5A20869 for ; Mon, 4 Nov 2019 15:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="jhLrhjSz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55D5A20869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRecE-00060e-BH for qemu-devel@archiver.kernel.org; Mon, 04 Nov 2019 10:50:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46979) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRebW-0005Sy-6F for qemu-devel@nongnu.org; Mon, 04 Nov 2019 10:49:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRebV-0005yZ-4m for qemu-devel@nongnu.org; Mon, 04 Nov 2019 10:49:18 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:37212) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRebQ-0005vE-UN; Mon, 04 Nov 2019 10:49:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=CGEC2ACnQHkfxir6I+MPs0JpJib6o9PO0Spq7QPYJso=; b=jhLrhjSzghnwNtnokUrLRCUKN9I9zL2+55lBGWLr6wrrEpr6norOSiKK05RfNlP2syiXWNnQKIFtpZhVfHIVTbAqnSskQL+zOgQt9JU561+caBUo0LGvyJ0lPin+a5fsI5LSn+emLmRCvcCRyI4o9wzAjMJemMqWiSBQ573a1qvax8uqlW3Ge9lPHRhd0Dc/X7BoEb48qtxDl7lT3YK4d1WQsT45LWJ5kD/fOPqLS9Q3t6YUBLpoTJtzGsMF1gVFArhnCeWQRVWf4m0RPJBv38zxB/XFcOI/0JYD2GcbrXaIW3MPE9Fa180jkVu0lyRo2pB4j/YVvcsaS556eYjQtQ==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1iRebK-0007s7-HS; Mon, 04 Nov 2019 16:49:06 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1iRebK-0001Bi-Ei; Mon, 04 Nov 2019 16:49:06 +0100 From: Alberto Garcia To: Max Reitz , Vladimir Sementsov-Ogievskiy , "qemu-block\@nongnu.org" Subject: Re: [RFC 0/3] block/file-posix: Work around XFS bug In-Reply-To: <5b67cf39-0ea1-d205-0e96-7b1148c7df19@redhat.com> References: <20191025095849.25283-1-mreitz@redhat.com> <02291bca-67d2-ed30-ac34-17641afbe397@virtuozzo.com> <0f75cbcf-e6c7-c74c-972b-22e7760a8b5c@redhat.com> <7ed9b8f0-2d8c-7bac-185e-9a1dd68fcce8@redhat.com> <5b67cf39-0ea1-d205-0e96-7b1148c7df19@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Mon, 04 Nov 2019 16:49:06 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , "qemu-devel@nongnu.org" , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon 04 Nov 2019 04:14:56 PM CET, Max Reitz wrote: >>> No, what I meant was that the original problem that led to >>> c8bb23cbdbe would go away. >>=20 >> Ah, right. Not quite, according to my numbers: >>=20 >> |--------------+----------------+-----------------+-------------| >> | Cluster size | subclusters=3Don | subclusters=3Doff | fallocate() | >> |--------------+----------------+-----------------+-------------| >> | 256 KB | 10182 IOPS | 966 IOPS | 14007 IOPS | >> | 512 KB | 7919 IOPS | 563 IOPS | 13442 IOPS | >> | 1024 KB | 5050 IOPS | 465 IOPS | 13887 IOPS | >> | 2048 KB | 2465 IOPS | 271 IOPS | 13885 IOPS | >> |--------------+----------------+-----------------+-------------| >>=20 >> There's obviously no backing image, and only the last column uses >> handle_alloc_space() / fallocate(). > > Thanks for providing some numbers! > > It was my impression, too, that subclusters wouldn=E2=80=99t solve it. B= ut it > didn=E2=80=99t seem like that big of a difference to me. Did you run this > with aio=3Dnative? (Because that=E2=80=99s where we have the XFS problem) Here's with aio=3Dnative |--------------+----------------+-----------------+-------------| | Cluster size | subclusters=3Don | subclusters=3Doff | fallocate() | |--------------+----------------+-----------------+-------------| | 256 KB | 19897 IOPS | 891 IOPS | 32194 IOPS | | 512 KB | 17881 IOPS | 436 IOPS | 33092 IOPS | | 1024 KB | 17050 IOPS | 341 IOPS | 32768 IOPS | | 2048 KB | 7854 IOPS | 207 IOPS | 30944 IOPS | |--------------+----------------+-----------------+-------------| Berto