From: Alberto Garcia <berto@igalia.com>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, qemu-stable@nongnu.org,
"Denis V. Lunev" <den@openvz.org>, Kevin Wolf <kwolf@redhat.com>,
Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH] block/throttle-groups: fix crash when enabling I/O limits on a busy disk
Date: Fri, 11 Sep 2026 12:52:45 +0200 [thread overview]
Message-ID: <w51se3ggiv6.fsf@igalia.com> (raw)
In-Reply-To: <20260908145554.3215221-2-den@openvz.org>
On Tue 08 Sep 2026 04:55:53 PM +02, Denis V. Lunev wrote:
> throttle_group_register_tgm() stores tgm->throttle_state before it takes
> tg->lock, so the I/O path can see a member whose group still has NULL
> tokens[] and an empty member list. A request in an iothread then reaches
> throttle_group_co_io_limits_intercept(), wins tg->lock ahead of the
> registering thread, and next_throttle_token() passes the NULL token to
> throttle_group_next_tgm(), which dereferences it:
Acked-by: Alberto Garcia <berto@igalia.com>
Berto
next prev parent reply other threads:[~2026-09-11 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 14:55 [PATCH 0/1] block/throttle-groups: fix a NULL token crash on group creation Denis V. Lunev
2026-09-08 14:55 ` [PATCH] block/throttle-groups: fix crash when enabling I/O limits on a busy disk Denis V. Lunev
2026-09-11 10:52 ` Alberto Garcia [this message]
2026-09-21 19:40 ` [PATCH 0/1] block/throttle-groups: fix a NULL token crash on group creation Denis V. Lunev
2026-09-22 14:47 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51se3ggiv6.fsf@igalia.com \
--to=berto@igalia.com \
--cc=den@openvz.org \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.