From: Alberto Garcia <berto@igalia.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: wencongyang2@huawei.com, zhanghailiang@xfusion.com,
arei.gonglei@huawei.com, xiechanglong.d@gmail.com,
hreitz@redhat.com, kwolf@redhat.com
Subject: Re: [PATCH] qapi/block-core: Improve x-blockdev-change documentation
Date: Wed, 12 Mar 2025 11:31:32 +0100 [thread overview]
Message-ID: <w51tt7y1qwr.fsf@igalia.com> (raw)
In-Reply-To: <20250311131715.1296101-1-armbru@redhat.com>
On Tue 11 Mar 2025 02:17:15 PM +01, Markus Armbruster wrote:
> The description of feature @unstable is three paragraphs. The second
> and third became part of the description by accident in commit
> 9fb49daabfb (qapi: Mark unstable QMP parts with feature 'unstable').
>
> The second paragraph describes a defect in terms of the
> implementation. Fine, but doesn't belong into user-facing
> documentation. Turn it into a TODO section.
>
> Rewrite everything else for clarity and completeness.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alberto Garcia <berto@igalia.com>
Berto
prev parent reply other threads:[~2025-03-12 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 13:17 [PATCH] qapi/block-core: Improve x-blockdev-change documentation Markus Armbruster
2025-03-12 10:31 ` Alberto Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51tt7y1qwr.fsf@igalia.com \
--to=berto@igalia.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.