From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56501)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1ZyF9v-00067Z-1r
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:29:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1ZyF9q-0006qP-0N
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:29:06 -0500
From: Alberto Garcia <berto@igalia.com>
In-Reply-To: <20151116034644.GD9498@stefanha-x1.localdomain>
References: <1447247832-14198-1-git-send-email-berto@igalia.com>
	<20151116034644.GD9498@stefanha-x1.localdomain>
Date: Mon, 16 Nov 2015 09:28:21 +0100
Message-ID: <w51vb92pcuy.fsf@maestria.local.igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals'
	a list of integers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On Mon 16 Nov 2015 04:46:44 AM CET, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>>  early_err:
>>      qemu_opts_del(opts);
>> +    QDECREF(interval_dict);
>> +    QDECREF(interval_list);
>
> There is a codepath that reaches here without initializing interval_dict
> or interval_list:
>
>   qemu_opts_absorb_qdict(opts, bs_opts, &error);
>   if (error) {
>       error_propagate(errp, error);
>       goto early_err;
>   }

You're right, I'll send a new version ASAP.

Berto