From: Alberto Garcia <berto@igalia.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, kwolf@redhat.com,
eblake@redhat.com, jean-louis@dupond.be,
andrey.drobyshev@virtuozzo.com, den@virtuozzo.com
Subject: Re: [PATCH v2 02/11] qcow2: simplify L2 entries accounting for discard-no-unref
Date: Thu, 16 May 2024 00:28:03 +0200 [thread overview]
Message-ID: <w51zfsqaex8.fsf@igalia.com> (raw)
In-Reply-To: <20240513063203.113911-3-andrey.drobyshev@virtuozzo.com>
On Mon 13 May 2024 09:31:54 AM +03, Andrey Drobyshev wrote:
> Commits 42a2890a and b2b10904 introduce handling of discard-no-unref
> option in discard_in_l2_slice() and zero_in_l2_slice(). They add even
> more if's when chosing the right l2 entry. What we really need for this
> option is the new entry simply to contain the same host cluster offset,
> no matter whether we unmap or zeroize the cluster. For that OR'ing with
> the old entry is enough.
>
> This patch doesn't change the logic and is pure refactoring.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
next prev parent reply other threads:[~2024-05-15 22:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 6:31 [PATCH v2 00/11] qcow2: make subclusters discardable Andrey Drobyshev
2024-05-13 6:31 ` [PATCH v2 01/11] qcow2: make function update_refcount_discard() global Andrey Drobyshev
2024-05-15 22:26 ` Alberto Garcia
2024-05-21 8:31 ` Alexander Ivanov
2024-05-13 6:31 ` [PATCH v2 02/11] qcow2: simplify L2 entries accounting for discard-no-unref Andrey Drobyshev
2024-05-15 22:28 ` Alberto Garcia [this message]
2024-05-21 8:32 ` Alexander Ivanov
2024-05-13 6:31 ` [PATCH v2 03/11] qcow2: put discard requests in the common queue when discard-no-unref enabled Andrey Drobyshev
2024-05-21 8:43 ` Alexander Ivanov
2024-05-13 6:31 ` [PATCH v2 04/11] block/file-posix: add trace event for fallocate() calls Andrey Drobyshev
2024-05-21 8:54 ` Alexander Ivanov
2024-05-24 6:40 ` Alberto Garcia
2024-05-13 6:31 ` [PATCH v2 05/11] iotests/common.rc: add disk_usage function Andrey Drobyshev
2024-05-21 8:56 ` Alexander Ivanov
2024-05-24 6:41 ` Alberto Garcia
2024-05-13 6:31 ` [PATCH v2 06/11] iotests/290: add test case to check 'discard-no-unref' option behavior Andrey Drobyshev
2024-05-21 9:09 ` Alexander Ivanov
2024-05-24 6:42 ` Alberto Garcia
2024-05-13 6:31 ` [PATCH v2 07/11] qcow2: add get_sc_range_info() helper for working with subcluster ranges Andrey Drobyshev
2024-05-21 9:17 ` Alexander Ivanov
2024-05-13 6:32 ` [PATCH v2 08/11] qcow2: zeroize the entire cluster when there're no non-zero subclusters Andrey Drobyshev
2024-05-21 9:27 ` Alexander Ivanov
2024-05-13 6:32 ` [PATCH v2 09/11] qcow2: make subclusters discardable Andrey Drobyshev
2024-05-21 10:41 ` Alexander Ivanov
2024-05-13 6:32 ` [PATCH v2 10/11] qcow2: zero_l2_subclusters: fall through to discard operation when requested Andrey Drobyshev
2024-05-21 10:46 ` Alexander Ivanov
2024-05-13 6:32 ` [PATCH v2 11/11] iotests/271: add test cases for subcluster-based discard/unmap Andrey Drobyshev
2024-05-21 10:50 ` Alexander Ivanov
2024-06-03 9:19 ` [PATCH v2 00/11] qcow2: make subclusters discardable Andrey Drobyshev
2024-06-10 9:53 ` Andrey Drobyshev
2024-06-17 7:39 ` Andrey Drobyshev
2024-06-24 7:43 ` Andrey Drobyshev
2024-07-08 7:06 ` Andrey Drobyshev
2024-07-15 7:44 ` Andrey Drobyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51zfsqaex8.fsf@igalia.com \
--to=berto@igalia.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jean-louis@dupond.be \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.