From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3768E39E6E4 for ; Sat, 13 Jun 2026 02:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781316796; cv=none; b=LyfTHGnM9saItDXe7uEjdS+TO5owhmWGG11fWIMoEmInncEV+jAHbTeMl2Yoo1HvLWUuq6GCTfIz/FOHpzvkcLXn51yyk4Nhm1IXZjPYi34AjdDd4ITZk44vxXi8kd3n1gEovHh7K7pBp8yNMaiW6XEhuQXkY0TCUu+IzDdSyws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781316796; c=relaxed/simple; bh=6cmijRI5V7P9USb4+x1RRVJ2PCaIYvLxOmNSxNpMftY=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=JSuFKvoUKG3dSzzdI2+fqeJCmqto0tsoM1e+6+mI8j+/hyKVRwW17boGDq9SJ4LAFa5vU6VgOw5dwEQRagwaUvtxv5QtTej1glXsELT6YNmUvl5SR/dj3XvYO+QPrXWcRqCyxwt18JuE8TJgMYGijCAxlkjvYdCEtjZJQxSQVfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pZmBJ8tb; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pZmBJ8tb" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-7e8b45dfb3dso20324327b3.3 for ; Fri, 12 Jun 2026 19:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781316794; x=1781921594; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rjnB0IRIF5mo49HLDOpqQWrW5AN9ELBnpM+0ifgLB8s=; b=pZmBJ8tbii3ukivutkXcOPmVPPQbA5L92wDAN/AByE7tlquxk90AmskL7MvKvFIRs9 2E5qQXRtAvuBbQs5lwajUqEZdGdGyr3lCZYrOksiaNy16mG8d5RH8S5G4zLm/TswSLqc kgLjcPU1xiBjjUenJXQZItnPXq8uD3dyBYBiz7Vh51hgatxK5flOQ5vuIxqwt10sGSvn Wz+CLC6nNLXfgJR2CWZOkNt/cvgn1TZjP/+wqF8CVY8LNlduI6DspWCrYlMYQbI8+sn/ B2U6ietQXoYEATJlj/x6Toa2dLmvDkJqVNi9lMdsv7LXmJqh1TAvPD5L76QitxR0hMx4 5hwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781316794; x=1781921594; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rjnB0IRIF5mo49HLDOpqQWrW5AN9ELBnpM+0ifgLB8s=; b=rtXtO4CvR3bjwtJrgqaOUnFJh6BxUBBSL7PYRjxP0AdMaJTdK7BUtTeCVdBqE1+JY/ epmJP6hfkXEOAvCTD67D/W03VfHrCILqUjcwVX5opG9ty2xBZKzU7xcbXnk5ZQnKaW1B 7ybBXG7CnYB79P5wyYIAiWeW8X5M2k5iqBQegIgD2cTqKeUsUtLtYqvXUdX7j1UoA+nX 6XuyDsBHslRW+/gkrKE2HQ60je4KVlB9ZQ0UoS4mOA4LWISJ6bHUNYhvay3c8/Kymi20 G7Ho/vb6BYCUDcsGzW1EoxQRejGcSMHMCEJ0yWaOIx61sYrDMMuRpSyPDMyCCRCBUhyW ugvw== X-Forwarded-Encrypted: i=1; AFNElJ/Gs+zuY3ei3jwBbLJAaEaB0OC1g1+JZOevIoWulgjsRTjEUysQF5VTwCsPYXI7denC9HmhrEE=@vger.kernel.org X-Gm-Message-State: AOJu0YyoyWxc4wc9pRWVEnN9Juw77PtTW8rOAT64kgkdDu90QIgr8McT ahelThKIyZ9giU6pWbcx+7Lxz5Kij+tmvB5trCVAObkOpQ/dajINi9us X-Gm-Gg: Acq92OEG28Q9XiqTeycUZ5MRKJNnUOJ9/OCY/ZX4WArPAky+9pRAk8fMubiYpI6neF/ CTr41awq/10C6dXNXRB3sHG62SpY9v9DzxCLogKfPt36mA8CS+opHiKG2zNtTvu4k4rsoMm9CLf DueognYTuW1XhszqhWZcx1EeiASfazOM/vrGxHas+jWstjfatNuDJTq7pVofk0CYCE2WBILbiNp MGuoMosg3LuoGJ8/tN/PDm+XdT5i8YRmYRmacjJTotgdh3WSFijqmQgXJJTr90/nzHP7jIm3eIw ma+SMFMDbzs28wrYSVhkuKuMlH3VDVPpt6VLUHaMSapGIWr7BelHlNJZnHzA7l7gfs9kPOyOw0B AvX365nXvGPgEaKZTNh1XjHPc8mAmqDoHq1KiXgdm2OPpMYU61vegyUMQp9yi6607ZV0SjFXRNZ ol0Cb3iW1IPXTW09DkFxvm/GZc4YkSa4Y/XJQrMo+IspR3QRw/2ya2dq9tnBlPm3/kXmbNgzHju DW7JZE= X-Received: by 2002:a05:690e:441c:b0:660:56ee:ebf1 with SMTP id 956f58d0204a3-66284e68df9mr1616587d50.22.1781316794269; Fri, 12 Jun 2026 19:13:14 -0700 (PDT) Received: from gmail.com (141.139.145.34.bc.googleusercontent.com. [34.145.139.141]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66274c675f6sm1955578d50.5.2026.06.12.19.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 19:13:13 -0700 (PDT) Date: Fri, 12 Jun 2026 22:13:13 -0400 From: Willem de Bruijn To: Breno Leitao , Willem de Bruijn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , sdf.kernel@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@meta.com Message-ID: In-Reply-To: References: <20260612-getsockopt_phase2-v1-0-7b01f1f5d106@debian.org> <20260612-getsockopt_phase2-v1-2-7b01f1f5d106@debian.org> Subject: Re: [PATCH net-next 2/2] udp: convert udp_lib_getsockopt to sockopt_t Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Breno Leitao wrote: > Hello Willem, > > On Fri, Jun 12, 2026 at 10:58:19AM -0400, Willem de Bruijn wrote: > > Breno Leitao wrote: > > > In preparation for converting the proto-layer getsockopt callbacks to the > > > sockopt_t interface, switch udp_lib_getsockopt() to take a sockopt_t. > > > > What is the benefit of this conversion? > > This enables kernel callers (io_uring, bpf, etc.) to invoke getsockopt > directly. The setsockopt() conversion previously used sockptr, but > Linus objected to that approach and suggested iov_iter instead. > > For full context, see: > https://lore.kernel.org/all/20260408-getsockopt-v3-0-061bb9cb355d@debian.org/ > > > It does add a lot more complexity and makes the code less obvious. > > I agree this adds complexity. Unfortunately, I don't see a simpler way > to enable getsockopt to work with non-__user addresses. Oh right, this is already applied for other protocols such as l2tp_ppp rds and smc.