Re: [PATCH net-next 3/4] psp: allow drivers to omit tx key add/del ops

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

Daniel Zahka wrote:
> Drivers that don't use an SADB for tx key storage don't have a use
> for psp_dev_ops::tx_key_add and psp_dev_ops::tx_key_del.
> 
> Allowing drivers to leave these as NULL gives PSP core a simple way to
> determine whether a driver utilizes an SADB, which in turn could
> affect how PSP core chooses to handle certain situations.
> 
> For example:
> - deciding if tx key deletion needs to be delayed during a rekeying
>   event to avoid in-flight packets using old key handles.
> - choosing whether or not to report device stats like SADB usage to
>   userspace, which only make sense if the driver uses on-device key
>   storage.
> 
> Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>