From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v2] selftests/net: convert so_txtime to drv-net
Date: Mon, 06 Apr 2026 12:55:30 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.1a194b4fc6bd0@gmail.com> (raw)
In-Reply-To: <20260406090231.63df3fac@kernel.org>
Jakub Kicinski wrote:
> On Sat, 04 Apr 2026 22:20:15 -0400 Willem de Bruijn wrote:
> > > +YNL_GEN_FILES := \
> > > + psp_responder \
> > > + so_txtime
> >
> > This should just go under TEST_GEN_FILES (sashiko)
> >
> > I don't quite understand the check_selftest check_new_files_makefile
> > failure.
>
> Glancing at the code you were missing the
>
> # end of YNL_GEN_FILES
>
> trailer.
>
> Those checkers are equally annoying and easy to run locally, they
> take a path to the modified file and say "good" / "bad".
Thanks. Indeed, I only learned about this yesterday. Ran it before v3.
Was super easy. Sharing for anyone else new to this:
git format-patch -1
mkdir /tmp/patches
mv 000* /tmp/patches
cd /tmp
git clone https://github.com/linux-netdev/nipa.git
cd nipa
./ingest_mdir.py --mdir /tmp/patches --tree ~/src/kernel/netdev/nn -t patch/check_selftest
--- output
Saving output and logs to: /tmp/tmp7zb9n8ka
Tree name unknown
[1] selftests/net: convert so_txtime to drv-net
Series level tests:
Patch level tests:
check_selftest OKAY Good format (5); New files in Makefile checked (1)
prev parent reply other threads:[~2026-04-06 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 1:44 [PATCH net-next v2] selftests/net: convert so_txtime to drv-net Willem de Bruijn
2026-04-05 2:20 ` Willem de Bruijn
2026-04-06 16:02 ` Jakub Kicinski
2026-04-06 16:55 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1a194b4fc6bd0@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.