From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Pengtao He <hept.hept.hept@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Mina Almasry <almasrymina@google.com>,
Jason Xing <kerneljasonxing@gmail.com>,
Michal Luczaj <mhal@rbox.co>,
Eric Biggers <ebiggers@google.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengtao He <hept.hept.hept@gmail.com>
Subject: Re: [PATCH net-next v5] net: avoid one loop iteration in __skb_splice_bits
Date: Tue, 19 Aug 2025 09:55:16 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.1ccfaff4b5510@gmail.com> (raw)
In-Reply-To: <20250819021551.8361-1-hept.hept.hept@gmail.com>
Pengtao He wrote:
> If *len is equal to 0 at the beginning of __splice_segment
> it returns true directly. But when decreasing *len from
> a positive number to 0 in __splice_segment, it returns false.
> The __skb_splice_bits needs to call __splice_segment again.
>
> Recheck *len if it changes, return true in time.
> Reduce unnecessary calls to __splice_segment.
>
> Signed-off-by: Pengtao He <hept.hept.hept@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2025-08-19 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 2:15 [PATCH net-next v5] net: avoid one loop iteration in __skb_splice_bits Pengtao He
2025-08-19 13:55 ` Willem de Bruijn [this message]
2025-08-21 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1ccfaff4b5510@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=hept.hept.hept@gmail.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.