From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: fib: restore ECMP balance from loopback
Date: Mon, 15 Dec 2025 16:45:11 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.1d692ef4130e8@gmail.com> (raw)
In-Reply-To: <d0b3f358-4e0a-42f3-84f0-cbcf19066d49@linux.dev>
Vadim Fedorenko wrote:
> On 13/12/2025 20:54, Willem de Bruijn wrote:
> > Vadim Fedorenko wrote:
> >> Preference of nexthop with source address broke ECMP for packets with
> >> source address from loopback interface. Original behaviour was to
> >> balance over nexthops while now it uses the latest nexthop from the
> >> group.
> >
> > How does the loopback device specifically come into this?
>
> It may be a dummy device as well. The use case is when there are 2
> physical interfaces and 1 service IP address, distributed by any
> routing protocol. The socket is bound to service, thus it's used in
> route selection.
Can you elaborate a bit more on this. Maybe in the commit message
itself. How is loopback relevant to this service IP.
prev parent reply other threads:[~2025-12-15 21:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-13 13:58 [PATCH net 1/2] net: fib: restore ECMP balance from loopback Vadim Fedorenko
2025-12-13 13:58 ` [PATCH net 2/2] selftests: fib_nexthops: Add test case for ipv4 multi nexthops Vadim Fedorenko
2025-12-13 21:18 ` Willem de Bruijn
2025-12-13 21:26 ` Vadim Fedorenko
2025-12-13 22:02 ` David Ahern
2025-12-15 6:59 ` Ido Schimmel
2025-12-15 16:13 ` David Ahern
2025-12-15 19:01 ` Vadim Fedorenko
2025-12-13 20:54 ` [PATCH net 1/2] net: fib: restore ECMP balance from loopback Willem de Bruijn
2025-12-13 21:22 ` Vadim Fedorenko
2025-12-15 21:45 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1d692ef4130e8@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.