From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xia Yan <yanxia@cmss.chinamobile.com>,
willemdebruijn.kernel@gmail.com, netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
yana06070@163.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, willemb@google.com,
tpluszz77@gmail.com
Subject: Re: [PATCH net v2 1/2] ipv6: fix cached route reuse for SO_MARK control messages
Date: Thu, 05 Nov 2026 22:01:29 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.1e8c4e152eca9@gmail.com> (raw)
In-Reply-To: <20261106021245.246267-1-yanxia@cmss.chinamobile.com>
Xia Yan wrote:
> Hi,
>
> Thanks for the review. v2 fixes SO_MARK sends, including the concurrent
> sk_mark case that came up during the v1 review. Sends without an SO_MARK
> cmsg keep the current behavior.
>
> Willem, you also raised the flowlabel and dscp cases in the v1 review:
> https://lore.kernel.org/netdev/willemdebruijn.kernel.6ba984cf38a@gmail.com/
>
> I'd like to keep the SO_MARK fix targeted at net and handle the
> remaining cache issues separately in net-next. Does that split make
> sense to you?
Agreed that those additional concerns should not block this patch.
Are they net-next material, or similar bugs and thus also net?
> I'll wait for your feedback on the scope before posting v3.
>
> v3 will also add a fwmark 0/0xffffffff prohibit rule to the
> connected-socket selftest, so reusing the cached route instead of doing
> a fresh lookup fails the explicit-zero cases.
>
> Thanks,
> Xia Yan
>
> pw-bot: cr
>
>
next prev parent reply other threads:[~2026-11-06 3:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 9:22 [PATCH net v2 1/2] ipv6: fix cached route reuse for SO_MARK control messages Xia Yan
2026-11-04 9:23 ` Xia Yan
2026-11-04 9:22 ` [PATCH net v2 2/2] selftests: net: exercise SO_MARK on connected sockets Xia Yan
2026-11-04 9:23 ` Xia Yan
2026-11-05 9:39 ` netdev-bot+sashiko
2026-11-04 9:29 ` [PATCH net v2 1/2] ipv6: fix cached route reuse for SO_MARK control messages netdev-bot+sinfo
2026-11-04 9:50 ` Xia Yan
2026-11-05 9:38 ` netdev-bot+sashiko
2026-11-06 2:13 ` Xia Yan
2026-11-06 3:01 ` Willem de Bruijn [this message]
2026-11-06 3:14 ` Willem de Bruijn
2026-11-09 1:58 ` Xia Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1e8c4e152eca9@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tpluszz77@gmail.com \
--cc=willemb@google.com \
--cc=yana06070@163.com \
--cc=yanxia@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.