From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Anubhav Singh <anubhavsinggh@google.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Coco Li <lixiaoyan@google.com>,
Anubhav Singh <anubhavsinggh@google.com>
Subject: Re: [PATCH net v2] selftests/net: fix out-of-order delivery of FIN in gro:tcp test
Date: Thu, 30 Oct 2025 08:26:51 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.1ebc537b3da9e@gmail.com> (raw)
In-Reply-To: <20251030062818.1562228-1-anubhavsinggh@google.com>
Anubhav Singh wrote:
> Due to the gro_sender sending data packets and FIN packets
> in very quick succession, these are received almost simultaneously
> by the gro_receiver. FIN packets are sometimes processed before the
> data packets leading to intermittent (~1/100) test failures.
>
> This change adds a delay of 100ms before sending FIN packets
> in gro:tcp test to avoid the out-of-order delivery. The same
> mitigation already exists for the gro:ip test.
>
> Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test")
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Anubhav Singh <anubhavsinggh@google.com>
> ---
> Changes in v2:
> - Add 'Shuah Khan <shuah@kernel.org>' to the CC list.
Remember to not repost within 24 hours:
https://kernel.org/doc/html/latest/process/maintainer-netdev.html#tl-dr
next prev parent reply other threads:[~2025-10-30 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 5:57 [PATCH net] selftests/net: fix out-of-order delivery of FIN in gro:tcp test Anubhav Singh
2025-10-30 6:28 ` [PATCH net v2] " Anubhav Singh
2025-10-30 12:26 ` Willem de Bruijn [this message]
2025-11-01 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1ebc537b3da9e@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=anubhavsinggh@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.