All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,  davem@davemloft.net
Cc: netdev@vger.kernel.org,  edumazet@google.com,  pabeni@redhat.com,
	 andrew+netdev@lunn.ch,  horms@kernel.org,
	 Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes
Date: Tue, 09 Jun 2026 14:44:15 -0400	[thread overview]
Message-ID: <willemdebruijn.kernel.2888ce77104d1@gmail.com> (raw)
In-Reply-To: <20260609180803.1093428-1-kuba@kernel.org>

Jakub Kicinski wrote:
> I noticed that so_txtime is only passing on NIPA setups which are
> looped within a single host. The cross-machine cases just flat out
> fail. The initial bug is obvious - the test does not deploy the binary.
> But even with that I think more work would be needed to sync the
> time / adjust the expectations for a dual-machine test.
> 
> Willem promised to follow up on the fundamental issues with 2-host
> setups :)

Yep.

> v2:
>  - rebase & add cfg.require_ipver(ipver) to the new case
> v1: https://lore.kernel.org/20260608173305.372987-1-kuba@kernel.org

Thanks for the rebase. I was just doing the same.
Still has my tags, but to leave no doubt:

Reviewed-by: Willem de Bruijn <willemb@google.com>

  parent reply	other threads:[~2026-06-09 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 18:08 [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes Jakub Kicinski
2026-06-09 18:08 ` [PATCH net-next v2 1/2] selftests: drv-net: so_txtime: remember to deploy the binaries Jakub Kicinski
2026-06-09 18:08 ` [PATCH net-next v2 2/2] selftests: drv-net: so_txtime: check IP versions Jakub Kicinski
2026-06-09 18:44 ` Willem de Bruijn [this message]
2026-06-10  2:48   ` [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.2888ce77104d1@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.