All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Neal Cardwell <ncardwell@google.com>,
	 Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	 Simon Horman <horms@kernel.org>,
	 Jamal Hadi Salim <jhs@mojatatu.com>,
	 Jiri Pirko <jiri@resnulli.us>,
	 netdev@vger.kernel.org,  eric.dumazet@gmail.com,
	 Praveen Kaligineedi <pkaligineedi@google.com>,
	 Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] net_sched: sch_fq: clear q->band_pkt_count[] in fq_reset()
Date: Tue, 03 Mar 2026 21:26:48 -0500	[thread overview]
Message-ID: <willemdebruijn.kernel.2d3a81ea23fb5@gmail.com> (raw)
In-Reply-To: <CADVnQyn30yeYsdu03Nw2037Vp=9+qY2G4yf1PSLD7JbgwoA-tA@mail.gmail.com>

Neal Cardwell wrote:
> On Tue, Mar 3, 2026 at 5:56 PM Eric Dumazet <edumazet@google.com> wrote:
> >
> > When/if a NIC resets, queues are deactivated by dev_deactivate_many(),
> > then reactivated when the reset operation completes.
> >
> > fq_reset() removes all the skbs from various queues.
> >
> > If we do not clear q->band_pkt_count[], these counters keep growing
> > and can eventually reach sch->limit, preventing new packets to be queued.
> >
> > Many thanks to Praveen for discovering the root cause.
> >
> > Fixes: 29f834aa326e ("net_sched: sch_fq: add 3 bands and WRR scheduling")
> > Diagnosed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Cc: Willem de Bruijn <willemb@google.com>
> > ---
> 
> Reviewed-by: Neal Cardwell <ncardwell@google.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

  reply	other threads:[~2026-03-04  2:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  1:56 [PATCH net] net_sched: sch_fq: clear q->band_pkt_count[] in fq_reset() Eric Dumazet
2026-03-04  2:09 ` Neal Cardwell
2026-03-04  2:26   ` Willem de Bruijn [this message]
2026-03-05  2:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.2d3a81ea23fb5@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.