All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	 netdev@vger.kernel.org
Cc: davem@davemloft.net,  kuba@kernel.org,  edumazet@google.com,
	 pabeni@redhat.com,  horms@kernel.org,  andrew+netdev@lunn.ch,
	 Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v7 6/6] selftests: drv-net: extend so_txtime with hw offload
Date: Mon, 31 Aug 2026 23:03:37 -0400	[thread overview]
Message-ID: <willemdebruijn.kernel.2d4ddab147812@gmail.com> (raw)
In-Reply-To: <20260831213221.1370774-7-willemdebruijn.kernel@gmail.com>

Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
> 
> Add two pacing hardware offload variants
> 
> 1. one that uses FQ to safely offload when within bounds.
> 2. one that uses pfifo_fast and thus forwards all packets.
> 
> Verify that the packets are paced in hardware with new flag '-H'.
> 
> Also increase rcvtimeout significantly to reduce flakiness. Especially
> for the new beyond_hw_horizon test, which is close to the 100ms limit.
> But update recv_verify_empty to take MSG_DONTWAIT. That last empty
> check must not delay each testcase by the receive timeout.
> 
> Hardware pacing offload can complete packets out of order. So the
> reverse_order test is expected to pass with pfifo_fast too.
> 
> Do not test ETF, which does not change its dequeue behavior based on
> pacing_offload_horizon.
> 
> Signed-off-by: Willem de Bruijn <willemb@google.com>

> +@ksft_variants(_test_variants_fq())
> +def test_so_txtime_pfifofast_mono_hw(cfg, ipver, args_tx, args_rx):
> +    """Run all variants of monotonic tests, without fq pacing sw backup."""
> +    cfg.require_ipver(ipver)
> +    cfg.require_nsim(nsim_test=False)
> +
> +    _dev_setup_pacing_offload(cfg)
> +    _qdisc_setup(cfg.ifname, "pfifo_fast")
> +
> +    # Expect all tests to pass, except beyond_hw_horizon without sw fallback.
> +    # It will send immediately, failing the receiver arrival bounds check.
> +    expect_pass = not args_tx == "a,70"

Will fix a style warning

> +    test_so_txtime(cfg, "mono", ipver, f"-H {args_tx}", args_rx, expect_pass)

      reply	other threads:[~2026-09-01  3:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 21:26 [PATCH net-next v7 0/6] hardware pacing offload Willem de Bruijn
2026-08-31 21:26 ` [PATCH net-next v7 1/6] net: rtnetlink: add pacing_offload_horizon attribute to net_device Willem de Bruijn
2026-08-31 21:26 ` [PATCH net-next v7 2/6] net_sched: sch_fq: clear past skb->tstamp if offloading pacing Willem de Bruijn
2026-08-31 21:26 ` [PATCH net-next v7 3/6] idpf: support pacing offload Willem de Bruijn
2026-09-01  3:02   ` Willem de Bruijn
2026-08-31 21:26 ` [PATCH net-next v7 4/6] selftests: drv-net: refactor so_txtime errqueue handling Willem de Bruijn
2026-08-31 21:26 ` [PATCH net-next v7 5/6] selftests: drv-net: in so_txtime tell apart sw from hw pacing Willem de Bruijn
2026-08-31 21:26 ` [PATCH net-next v7 6/6] selftests: drv-net: extend so_txtime with hw offload Willem de Bruijn
2026-09-01  3:03   ` Willem de Bruijn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.2d4ddab147812@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.