All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>,
	 netdev@vger.kernel.org,  pabeni@redhat.com,
	 ecree.xilinx@gmail.com,  willemdebruijn.kernel@gmail.com
Cc: davem@davemloft.net,  edumazet@google.com,  kuba@kernel.org,
	 horms@kernel.org,  corbet@lwn.net,  saeedm@nvidia.com,
	 tariqt@nvidia.com,  mbloch@nvidia.com,  leon@kernel.org,
	 dsahern@kernel.org,  ncardwell@google.com,  kuniyu@google.com,
	 shuah@kernel.org,  sdf@fomichev.me,
	 aleksander.lobakin@intel.com,  florian.fainelli@broadcom.com,
	 alexander.duyck@gmail.com,  linux-kernel@vger.kernel.org,
	 linux-net-drivers@amd.com,
	 Richard Gobert <richardbgobert@gmail.com>
Subject: Re: [PATCH net-next v8 3/5] net: gso: restore ids of outer ip headers correctly
Date: Tue, 23 Sep 2025 17:26:50 -0400	[thread overview]
Message-ID: <willemdebruijn.kernel.2d533675f308@gmail.com> (raw)
In-Reply-To: <20250923085908.4687-4-richardbgobert@gmail.com>

Richard Gobert wrote:
> Currently, NETIF_F_TSO_MANGLEID indicates that the inner-most ID can
> be mangled. Outer IDs can always be mangled.
> 
> Make GSO preserve outer IDs by default, with NETIF_F_TSO_MANGLEID allowing
> both inner and outer IDs to be mangled.
> 
> This commit also modifies a few drivers that use SKB_GSO_FIXEDID directly.
> 
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
> Reviewed-by: Edward Cree <ecree.xilinx@gmail.com> # for sfc

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks for added the pointer to segmentation-offloads.rst.

  reply	other threads:[~2025-09-23 21:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  8:59 [PATCH net-next v8 0/5] net: gso: restore outer ip ids correctly Richard Gobert
2025-09-23  8:59 ` [PATCH net-next v8 1/5] net: gro: remove is_ipv6 from napi_gro_cb Richard Gobert
2025-09-23  8:59 ` [PATCH net-next v8 2/5] net: gro: only merge packets with incrementing or fixed outer ids Richard Gobert
2025-09-23  8:59 ` [PATCH net-next v8 3/5] net: gso: restore ids of outer ip headers correctly Richard Gobert
2025-09-23 21:26   ` Willem de Bruijn [this message]
2025-09-23  8:59 ` [PATCH net-next v8 4/5] net: gro: remove unnecessary df checks Richard Gobert
2025-09-23  8:59 ` [PATCH net-next v8 5/5] selftests/net: test ipip packets in gro.sh Richard Gobert
2025-09-25 10:50 ` [PATCH net-next v8 0/5] net: gso: restore outer ip ids correctly patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=willemdebruijn.kernel.2d533675f308@gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=alexander.duyck@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=mbloch@nvidia.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardbgobert@gmail.com \
    --cc=saeedm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.