From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
shenjian15@huawei.com, salil.mehta@huawei.com,
shaojijie@huawei.com, andrew+netdev@lunn.ch,
saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
leon@kernel.org, ecree.xilinx@gmail.com, dsahern@kernel.org,
ncardwell@google.com, kuniyu@google.com, shuah@kernel.org,
sdf@fomichev.me, ahmed.zaki@intel.com,
aleksander.lobakin@intel.com, linux-kernel@vger.kernel.org,
linux-net-drivers@amd.com,
Richard Gobert <richardbgobert@gmail.com>
Subject: Re: [PATCH net-next 1/5] net: gro: remove is_ipv6 from napi_gro_cb
Date: Fri, 15 Aug 2025 06:17:30 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.2d92c3db94507@gmail.com> (raw)
In-Reply-To: <20250814114030.7683-2-richardbgobert@gmail.com>
Richard Gobert wrote:
> Remove is_ipv6 from napi_gro_cb and use sk->sk_family instead.
> This frees up space for another ip_fixedid bit that will be added
> in the next commit.
>
> udp_sock_create always creates either a AP_INET or a AF_INET6 socket,
> so using sk->sk_family is reliable.
In general, IPv6 socket can accept IPv4 packets. See also
cfg->ipv6_v6only in udp_sock_create6.
Not sure about fou, but are we sure that such AF_INET6 sockets
cannot receive flows with !is_ipv6.
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
next prev parent reply other threads:[~2025-08-15 10:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 11:40 [PATCH net-next 0/5] net: gso: restore outer ip ids correctly Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 1/5] net: gro: remove is_ipv6 from napi_gro_cb Richard Gobert
2025-08-14 20:45 ` Florian Fainelli
2025-08-15 10:17 ` Willem de Bruijn [this message]
2025-08-18 11:33 ` Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 2/5] net: gro: only merge packets with incrementing or fixed outer ids Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 3/5] net: gso: restore ids of outer ip headers correctly Richard Gobert
2025-08-15 10:23 ` Willem de Bruijn
2025-08-15 13:00 ` Willem de Bruijn
2025-08-18 11:46 ` Richard Gobert
2025-08-18 11:58 ` Willem de Bruijn
2025-08-18 14:07 ` Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 4/5] net: gro: remove unnecessary df checks Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 5/5] selftests/net: test ipip packets in gro.sh Richard Gobert
2025-08-14 19:42 ` Jakub Kicinski
2025-08-18 12:06 ` Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.2d92c3db94507@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=mbloch@nvidia.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sdf@fomichev.me \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.