From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Greg Donald <gdonald@gmail.com>,
linux-wireless@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 4/4] Staging: rtl8723au: core: Remove unused variable
Date: Thu, 10 Sep 2015 22:07:29 -0400 [thread overview]
Message-ID: <wrfj4mj1emji.fsf@redhat.com> (raw)
In-Reply-To: <1440241094-5927-4-git-send-email-shraddha.6596@gmail.com> (Shraddha Barke's message of "Sat, 22 Aug 2015 16:28:14 +0530")
Shraddha Barke <shraddha.6596@gmail.com> writes:
> This patch discards the variable as it is not used anywhere throughout
> the kernel.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_security.c | 9 ---------
> 1 file changed, 9 deletions(-)
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
> index 3d40bab..82518cd 100644
> --- a/drivers/staging/rtl8723au/core/rtw_security.c
> +++ b/drivers/staging/rtl8723au/core/rtw_security.c
> @@ -608,7 +608,6 @@ int rtw_tkip_encrypt23a(struct rtw_adapter *padapter,
> u8 hw_hdr_offset = 0;
> struct arc4context mycontext;
> int curfragnum, length;
> - u32 prwskeylen;
> u8 *pframe, *payload, *iv, *prwskey;
> union pn48 dot11txpn;
> struct sta_info *stainfo;
> @@ -655,8 +654,6 @@ int rtw_tkip_encrypt23a(struct rtw_adapter *padapter,
> else
> prwskey = &stainfo->dot118021x_UncstKey.skey[0];
>
> - prwskeylen = 16;
> -
> /* 4 start to encrypt each fragment */
> for (curfragnum = 0; curfragnum < pattrib->nr_frags; curfragnum++) {
> iv = pframe + pattrib->hdrlen;
> @@ -719,7 +716,6 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
> u32 actual_crc, expected_crc;
> struct arc4context mycontext;
> int length;
> - u32 prwskeylen;
> u8 *pframe, *payload, *iv, *prwskey;
> union pn48 dot11txpn;
> struct sta_info *stainfo;
> @@ -749,12 +745,10 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
> goto exit;
> }
> prwskey = psecuritypriv->dot118021XGrpKey[prxattrib->key_index].skey;
> - prwskeylen = 16;
> } else {
> RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> "%s: stainfo!= NULL!!!\n", __func__);
> prwskey = &stainfo->dot118021x_UncstKey.skey[0];
> - prwskeylen = 16;
> }
>
> iv = pframe + prxattrib->hdrlen;
> @@ -1288,7 +1282,6 @@ int rtw_aes_encrypt23a(struct rtw_adapter *padapter,
> { /* exclude ICV */
> /* Intermediate Buffers */
> int curfragnum, length;
> - u32 prwskeylen;
> u8 *pframe, *prwskey;
> u8 hw_hdr_offset = 0;
> struct sta_info *stainfo;
> @@ -1335,8 +1328,6 @@ int rtw_aes_encrypt23a(struct rtw_adapter *padapter,
> else
> prwskey = &stainfo->dot118021x_UncstKey.skey[0];
>
> - prwskeylen = 16;
> -
> for (curfragnum = 0; curfragnum < pattrib->nr_frags; curfragnum++) {
> /* 4 the last fragment */
> if ((curfragnum + 1) == pattrib->nr_frags) {
prev parent reply other threads:[~2015-09-11 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 10:58 [PATCH 1/4] Staging: rtl8192e: rtl_core.c: Remove unused variable Shraddha Barke
2015-08-22 10:58 ` [PATCH 2/4] Staging: rtl8192e: r8192E_dev.c: " Shraddha Barke
2015-08-22 10:58 ` [PATCH 3/4] Staging: rtl819u: ieee80211: " Shraddha Barke
2015-08-22 10:58 ` [PATCH 4/4] Staging: rtl8723au: core: " Shraddha Barke
2015-09-11 2:07 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfj4mj1emji.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.