All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [mdadm PATCH] Introduce enum flag_mode for setting and clearing flags.
Date: Tue, 29 Nov 2016 17:12:39 -0500	[thread overview]
Message-ID: <wrfj60n69bqg.fsf@redhat.com> (raw)
In-Reply-To: <877f7m7xng.fsf@notabene.neil.brown.name> (NeilBrown's message of "Wed, 30 Nov 2016 09:02:11 +1100")

NeilBrown <neilb@suse.com> writes:
> We currently use '1' to indicate that a flag (writemostly or failfast)
> needs to be set, and '2' to indicate that it needs to be cleared.
>
> Using magic number like this is not a best-practice.
>
> So replaced them with values from a enum.
>
> No functional change.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>
> Ask, and you shall receive :-)

Darn, are you trying ot put me to work?

Applied!

Thanks,
Jes

      reply	other threads:[~2016-11-29 22:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  5:16 [PATCH/RFC] add "failfast" support for raid1/raid10 NeilBrown
2016-11-18  5:16 ` [md PATCH 1/6] md/failfast: add failfast flag for md to be used by some personalities NeilBrown
2016-11-18  5:16 ` [md PATCH 2/6] md: Use REQ_FAILFAST_* on metadata writes where appropriate NeilBrown
2016-11-18  5:16 ` [md PATCH 4/6] md/raid1: add failfast handling for writes NeilBrown
2016-11-18  5:16 ` [md PATCH 3/6] md/raid1: add failfast handling for reads NeilBrown
2016-11-18  5:16 ` [md PATCH 6/6] md/raid10: add failfast handling for writes NeilBrown
2016-11-18  5:16 ` [md PATCH 5/6] md/raid10: add failfast handling for reads NeilBrown
2016-11-18  7:09 ` [PATCH/RFC] add "failfast" support for raid1/raid10 Hannes Reinecke
2016-11-18 15:41 ` Jack Wang
2016-11-24  4:47   ` NeilBrown
2016-11-24 16:06     ` Jack Wang
2016-11-22  2:02 ` Shaohua Li
2016-11-24 23:55   ` [mdadm PATCH] Add failfast support NeilBrown
2016-11-28 13:53     ` Jes Sorensen
2016-11-29 22:02       ` [mdadm PATCH] Introduce enum flag_mode for setting and clearing flags NeilBrown
2016-11-29 22:12         ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfj60n69bqg.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.