From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Bruno Randolf <br1@einfach.org>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start
Date: Fri, 23 Oct 2015 16:31:58 -0400 [thread overview]
Message-ID: <wrfj611xba2p.fsf@redhat.com> (raw)
In-Reply-To: <5628E9AB.1060907@einfach.org> (Bruno Randolf's message of "Thu, 22 Oct 2015 14:50:35 +0100")
Bruno Randolf <br1@einfach.org> writes:
> On 10/22/2015 02:42 PM, Jes Sorensen wrote:
>> Making things work against random kernel versions of OpenWRT is not
>> particularly "credible". If the driver needs hacks to work with older
>> kernels, then they should be applied for the older kernels. Linux does
>> not have a history of carrying hacks in current drivers to accommodate
>> older kernels.
>
> Well forget OpenWRT. The point is that this is not a hack - it's the
> behavior that mac80211 expects and documents and moreover it does NOT
> pass more data frames than before.
>
> It does not pass more data frames before association because the RCR
> RCR_ACCEPT_AP bit is not set and the RCR_CHECK_BSSID_* bits are set.
I have gone back and looked more at the vendor drivers over this issue.
Most versions of the vendor driver consistently mess with both FLTMAP*
and RCR, and disable packets when they go into a non-assoc state, but
non-assoc to the vendor driver also means non-AP, non-monitor, etc.
I really would like to know more about the difference between RCR and
FLTMAP registers - Larry is there a chance you could try and ping your
Realtek contacts about this?
For now I have applied your patch and pushed it into both branches.
Cheers,
Jes
next prev parent reply other threads:[~2015-10-23 20:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 21:28 [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start Bruno Randolf
2015-10-21 23:13 ` Jes Sorensen
2015-10-22 7:50 ` Bruno Randolf
2015-10-22 13:10 ` Jes Sorensen
2015-10-22 13:22 ` Bruno Randolf
2015-10-22 13:42 ` Jes Sorensen
2015-10-22 13:50 ` Bruno Randolf
2015-10-23 20:31 ` Jes Sorensen [this message]
2015-10-23 16:30 ` Larry Finger
2015-10-30 19:32 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfj611xba2p.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.