From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH] super1: make write_bitmap1 compatible with previous mdadm versions Date: Wed, 19 Oct 2016 11:21:31 -0400 Message-ID: References: <1476253447-19865-1-git-send-email-gqjiang@suse.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1476253447-19865-1-git-send-email-gqjiang@suse.com> (Guoqing Jiang's message of "Wed, 12 Oct 2016 02:24:07 -0400") Sender: linux-raid-owner@vger.kernel.org To: Guoqing Jiang Cc: linux-raid@vger.kernel.org, Neil Brown List-Id: linux-raid.ids Guoqing Jiang writes: > For older mdadm version, v1.x metadata has different bitmap_offset, > we can't ensure all the bitmaps are on a 4K boundary since writing > 4K for bitmap could corrupt the superblock, and Anthony reported > the bug about it at below link. > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837964 > > So let's check about the alignment for bitmap_offset before set > the boundary to 4096 unconditionally. Thanks for Neil's detailed > explanation. > > Reported-by: Anthony DeRobertis > Fixes: 95a05b37e8eb ("Create n bitmaps for clustered mode") > Cc: Neil Brown > Signed-off-by: Guoqing Jiang > --- > super1.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Applied! Thanks, Jes