From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: linux-raid@vger.kernel.org, shli@fb.com
Subject: Re: [PATCH v3] mdadm: fix a buffer overflow
Date: Mon, 12 Sep 2016 12:51:55 -0400 [thread overview]
Message-ID: <wrfj8tuxgixg.fsf@redhat.com> (raw)
In-Reply-To: <1473358867-4114379-1-git-send-email-songliubraving@fb.com> (Song Liu's message of "Thu, 8 Sep 2016 11:21:07 -0700")
Song Liu <songliubraving@fb.com> writes:
> struct mdp_superblock_1.set_name is 32B long, but struct mdinfo.name
> is 33B long. So we need strncpy instead strcpy to avoid buffer
> overflow.
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> super1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied thanks!
Note there is at least one place with a str operation hardcoding the
length of set_name to 32. Would you mind fixing that too?
Cheers,
Jes
prev parent reply other threads:[~2016-09-12 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 18:21 [PATCH v3] mdadm: fix a buffer overflow Song Liu
2016-09-12 16:51 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfj8tuxgixg.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.