From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH] mdadm --detail --scan causes SIGABRT Date: Fri, 10 Jun 2016 13:48:04 -0400 Message-ID: References: <575A4018.8050500@redhat.com> <2F74FF87-7E89-4452-8F90-53923B1B2E80@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <2F74FF87-7E89-4452-8F90-53923B1B2E80@redhat.com> (Nikhil Kshirsagar's message of "Fri, 10 Jun 2016 13:41:11 -0400 (EDT)") Sender: linux-raid-owner@vger.kernel.org To: Nikhil Kshirsagar Cc: linux-raid@vger.kernel.org List-Id: linux-raid.ids Nikhil Kshirsagar writes: > Hi Jes , > > Would it help to examine the core file ? It's present on the machine > and location specified in the bz comments . That's how I saw the data > structure that had the issue . Indeed there are other device names > where the name does not overflow since they are 32 bytes (which is why > I chose this value) or where the name *does* get truncated. However > this truncation does not seem to happen for de->d_name which is then > copied into dev->sys_name. > > As for allocating an appropriate size on the heap instead of a static > array it does make sense and I can correct the fix to do that but > there are lots of other device names which are static arrays. So which > ones do we change ? This is the tricky part, sys_name is used in a lot of places in different ways. Do you know if they have a /dev/oczpcie_11_0_ssd on the system, and if they do, how did that device get created? Cheers, Jes