From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH] md: raid5: add prerequisite to run underneath dm-raid Date: Mon, 09 May 2016 16:47:02 -0400 Message-ID: References: <1462809009-2809-1-git-send-email-heinzm@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1462809009-2809-1-git-send-email-heinzm@redhat.com> (heinzm@redhat.com's message of "Mon, 9 May 2016 17:50:09 +0200") Sender: linux-raid-owner@vger.kernel.org To: heinzm@redhat.com Cc: linux-raid@vger.kernel.org List-Id: linux-raid.ids heinzm@redhat.com writes: > From: Heinz Mauelshagen > > In case md runs underneath the dm-raid target, the mddev does not have > a request queue or gendisk, thus avoid accesses. > > This patch adds a missing conditional to the raid5 personality. > > > Signed-of-by: Heinz Mauelshagen > > > --- > drivers/md/raid5.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index 8ab8b65..ce79ce6 100644 > --- a/drivers/md/raid5.c > +++ b/drivers/md/raid5.c > @@ -7574,8 +7574,10 @@ static void raid5_finish_reshape(struct mddev *mddev) > > if (mddev->delta_disks > 0) { > md_set_array_sectors(mddev, raid5_size(mddev, 0, 0)); > - set_capacity(mddev->gendisk, mddev->array_sectors); > - revalidate_disk(mddev->gendisk); > + if (mddev->queue) { > + set_capacity(mddev->gendisk, mddev->array_sectors); > + revalidate_disk(mddev->gendisk); > + } Since we're in the code taste mode, this is a reminder that kernel code is 80 characters per line :) Jes