From: jes.sorensen@gmail.com
To: NeilBrown <neilb@suse.com>
Cc: Linux-RAID <linux-raid@vger.kernel.org>
Subject: Re: [mdadm PATCH 4/5] Add 'force' flag to *hot_remove_disk().
Date: Tue, 28 Mar 2017 14:33:18 -0400 [thread overview]
Message-ID: <wrfja885fdzl.fsf@gmail.com> (raw)
In-Reply-To: <149058581604.15679.9993360149817038150.stgit@noble> (NeilBrown's message of "Mon, 27 Mar 2017 14:36:56 +1100")
NeilBrown <neilb@suse.com> writes:
> In rare circumstances, the short period that *hot_remove_disk()
> waits isn't long enough to IO to complete. This particularly happens
> when a device is failing and many retries are still happening.
>
> We don't want to increase the normal wait time for "mdadm --remove"
> as that might be use just to test if a device is active or not, and a
> delay would be problematic.
> So allow "--force" to mean that mdadm should try extra hard for a
> --remove to complete, waiting up to 5 seconds.
>
> Note that this patch fixes a comment which claim the previous
> wait time was half a second, where it was really 50msec.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> Grow.c | 2 +-
> Manage.c | 10 +++++-----
> mdadm.h | 4 ++--
> util.c | 10 +++++-----
> 4 files changed, 13 insertions(+), 13 deletions(-)
Applied!
Thanks,
Jes
next prev parent reply other threads:[~2017-03-28 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 3:36 [mdadm PATCH 0/5] Assorted mdadm patch NeilBrown
2017-03-27 3:36 ` [mdadm PATCH 1/5] udev-md-raid-assembly.rules: Skip non-ready devices NeilBrown
2017-03-27 3:36 ` [mdadm PATCH 2/5] Retry HOT_REMOVE_DISK a few times NeilBrown
2017-03-27 7:51 ` 王金浦
2017-03-27 3:36 ` [mdadm PATCH 5/5] Detail: handle non-existent arrays better NeilBrown
2017-03-28 18:34 ` jes.sorensen
2017-03-27 3:36 ` [mdadm PATCH 4/5] Add 'force' flag to *hot_remove_disk() NeilBrown
2017-03-27 8:05 ` 王金浦
2017-03-28 18:33 ` jes.sorensen [this message]
2017-03-27 3:36 ` [mdadm PATCH 3/5] Introduce sys_hot_remove_disk() NeilBrown
2017-03-28 18:33 ` jes.sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfja885fdzl.fsf@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.