From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org, gregkh@linuxfoundation.org,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8723au: create macro get_max_rate
Date: Mon, 27 Oct 2014 06:46:04 +0100 [thread overview]
Message-ID: <wrfja94icbfn.fsf@redhat.com> (raw)
In-Reply-To: <1414368300-9596-1-git-send-email-paulmcquad@gmail.com> (Paul McQuade's message of "Mon, 27 Oct 2014 00:05:00 +0000")
Paul McQuade <paulmcquad@gmail.com> writes:
> create marco for max_rate values
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_ieee80211.c | 58 ++++++++++++--------------
> 1 file changed, 26 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> index 6274cb3..4c0414d 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> @@ -13,6 +13,8 @@
> *
> ******************************************************************************/
> #define _IEEE80211_C
> +#define get_max_rate(r1, r2, r3, r4) \
> + (bw_40MHz ? (short_GI_40 ? r1 : r2) : (short_GI_20 ? r3 : r4))
NACK!
Don't hide parameters like that!
Jes
next prev parent reply other threads:[~2014-10-27 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 0:05 [PATCH] staging: rtl8723au: create macro get_max_rate Paul McQuade
2014-10-27 0:40 ` Joe Perches
2014-10-27 5:46 ` Jes Sorensen [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-26 20:00 Paul McQuade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfja94icbfn.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.