Re: [MDADM PATCH 2/2] Specify suitable size when write to buffer

[jes.sorensen@gmail.com]

Xiao Ni <xni@redhat.com> writes:
> ---
>  Detail.c      | 2 +-
>  super-intel.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Detail.c b/Detail.c
> index 509b0d4..f4d4241 100644
> --- a/Detail.c
> +++ b/Detail.c
> @@ -575,7 +575,7 @@ This is pretty boring
>  			printf("  Member Arrays :");
>  
>  			while (dir && (de = readdir(dir)) != NULL) {
> -				char path[200];
> +				char path[320];
>  				char vbuf[1024];
>  				int nlen = strlen(sra->sys_name);
>  				dev_t devid;
> diff --git a/super-intel.c b/super-intel.c
> index d5e9517..ea50265 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -1811,7 +1811,7 @@ static void examine_super_imsm(struct supertype *st, char *homehost)
>  	__u32 reserved = imsm_reserved_sectors(super, super->disks);
>  	struct dl *dl;
>  
> -	snprintf(str, MPB_SIG_LEN, "%s", mpb->sig);
> +	snprintf(str, MAX_SIGNATURE_LENGTH, "%s", mpb->sig);
>  	printf("          Magic : %s\n", str);
>  	snprintf(str, strlen(MPB_VERSION_RAID0), "%s", get_imsm_version(mpb));
>  	printf("        Version : %s\n", get_imsm_version(mpb));

Hi Xiao,

This is really two independent changes, so they should come in two
seperate patches. All the patches needs their own commit messages and
signed-off-by lines.

Thanks,
Jes