From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, dledford@redhat.com, harald@redhat.com
Subject: Re: [PATCH 1/3] Add support for launching mdmon via systemctl instead of fork/exec
Date: Fri, 25 Jan 2013 16:05:31 +0100 [thread overview]
Message-ID: <wrfjd2wtl2v8.fsf@redhat.com> (raw)
In-Reply-To: <wrfjham5ldm6.fsf@redhat.com> (Jes Sorensen's message of "Fri, 25 Jan 2013 12:13:21 +0100")
Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>> NeilBrown <neilb@suse.de> writes:
>>> - I have come to the conclusion that --offroot is a bad idea. We should
>>> just make that the default. No matter whether the array is providing the
>>> root filesystem or not, I never want systemd (or anything else) to kill
>>> mdmon. I want it to remain in control. So the systemctl handling should
>>> assume offroot. e.g. there should only be one .service file.
>>
>> Ok I guess the question is what happens if an array is shut down in
>> userland, does it take mdmon down manually once it is finished with it?
>> We need this to happen, because otherwise we end up with a dangling
>> mdmon process once we reboot, if the IMSM array wasn't assembled in the
>> initrd.
>
> I have been digging some more into this. Basically it looks like we can
> nuke the --offroot argument and simply default to running that way.
>
> On the bad side, we need two different .service files, one for on the
> initrd and one for post system boot, due to different condition
> requiremnts. The question is whether to name them the same, and just
> have dracut know about the magic initrd version or if we want to try for
> the two versions.
Very odd - more testing and it looks like this may not be a problem
after all, but instead because something went wrong during the creation
of the initrd in my testing. It does make me a little concerned if this
can happen to users who are installing an update, but with nothing more
than a single incident there isn't much I can do.
I will look at a set of patches.
Jes
next prev parent reply other threads:[~2013-01-25 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 13:22 [PATCH v2 0/3] support launching mdmon via systemctl Jes.Sorensen
2013-01-21 13:22 ` [PATCH 1/3] Add support for launching mdmon via systemctl instead of fork/exec Jes.Sorensen
2013-01-22 5:46 ` NeilBrown
2013-01-22 7:33 ` Jes Sorensen
2013-01-25 11:13 ` Jes Sorensen
2013-01-25 15:05 ` Jes Sorensen [this message]
2013-01-21 13:22 ` [PATCH 2/3] systemd .service files for launching mdmon via systemctl Jes.Sorensen
2013-01-21 13:22 ` [PATCH 3/3] execl() only returns in case of error Jes.Sorensen
2013-01-22 5:48 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjd2wtl2v8.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=harald@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.