All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Baole Ni <baolex.ni@intel.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 02 Aug 2016 08:49:18 -0400	[thread overview]
Message-ID: <wrfjinvjfi9d.fsf@redhat.com> (raw)
In-Reply-To: <20160802120228.13716-1-baolex.ni@intel.com> (Baole Ni's message of "Tue, 2 Aug 2016 20:02:28 +0800")

Baole Ni <baolex.ni@intel.com> writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  drivers/staging/vt6656/main_usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Excuse me, but why are you CC'ing everybody and their 217 cousins on
these patches?

The fact that someone had a patch applied in a directory close to this
file within the last 3 years is not justification for spamming them with
this.

Jes

      reply	other threads:[~2016-08-02 12:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 12:02 [PATCH 0955/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:49 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjinvjfi9d.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=baolex.ni@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.