From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH 1/4 v2] mdadm: bad block support for external metadata - initialization Date: Mon, 28 Nov 2016 08:43:28 -0500 Message-ID: References: <1477558425-13332-1-git-send-email-tomasz.majchrzak@intel.com> <20161124140103.GA8047@proton.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Jes Sorensen's message of "Thu, 24 Nov 2016 10:53:36 -0500") Sender: linux-raid-owner@vger.kernel.org To: Tomasz Majchrzak Cc: linux-raid@vger.kernel.org List-Id: linux-raid.ids Jes Sorensen writes: > Tomasz Majchrzak writes: >> On Thu, Oct 27, 2016 at 10:53:42AM +0200, Tomasz Majchrzak wrote: >>> If metadata handler provides support for bad blocks, tell md by writing >>> 'external_bbl' to rdev state file (both on create and assemble), >>> followed by a list of known bad blocks written via sysfs 'bad_blocks' >>> file. >>> >>> Signed-off-by: Tomasz Majchrzak >>> Reviewed-by: Artur Paszkiewicz >>> --- >>> mdadm.h | 13 +++++++++++++ >>> sysfs.c | 29 ++++++++++++++++++++++++++++- >>> 2 files changed, 41 insertions(+), 1 deletion(-) >> >> Hi Jes, >> >> Do you have any comments for this patch set? It is a generic code for bad >> block support for external metadata. It comes ahead of my other patch set >> which provides IMSM implementation of new functionality. >> >> Regards, >> >> Tomek > > Hi Tomek, > > I thought I had responded to this one - I'll have a look early next week > (holiday here). Tomek, It mostly look fine, there is a nitpick in patch 1/4. In general I discourage the use of unnecessary parenthesis in multi case if statements, but it's not a showstopper. Ie. if ((foo == x) && (bar != y)) If you send me an updated 1/4 then I should be able to apply it. and of course, always use a cover letter when sending out multi-patch sets in the future. Cheers, Jes