From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Lobachevskii Vitalii <silverunicorn2011@yandex.ru>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org
Subject: Re: rtl8192ce
Date: Thu, 25 Aug 2016 09:17:54 -0400 [thread overview]
Message-ID: <wrfjmvk1asxp.fsf@redhat.com> (raw)
In-Reply-To: <72b958e1-0200-cd6f-2012-e04ff6fb74cb@yandex.ru> (Lobachevskii Vitalii's message of "Thu, 25 Aug 2016 14:23:12 +0300")
Lobachevskii Vitalii <silverunicorn2011@yandex.ru> writes:
> Hello,
>
> The RTL8192CE device seems to work fine without any firmware, so you may
> make it fully optional, removing dependency on FW_LOADER. Of course that
> require some patching, but if I understood the driver internals
> correctly, simple complete(&rtlpriv->firmware_loading_complete); would
> be enough when firmware loading machinery is unavailable, that is, when
> request_firmware_nowait returns -EINVAL (currently that may only happen
> in improperly configured or patched kernels, like Linux-libre; see
> attached messages for more information)
>
> Of course I will try to fix Linux-libre “deblobbing” technique, as it
> should never break anything that may work without a firmware. But
> anyway, if a device and its driver may work without a certain kernel
> feature, that feature should not be selected, I think.
The realtek devices all require firmwere to operate correctly,
including the 8192c series. There are a bunch of commands flying back
and forth between the driver and the firmware.
If your device happens to work without loading the firmware then you
have an old firmware blob loaded.
At least this is the case for the USB version of the device, and I find
it highly unlikely the PCIe version is any different.
Trying to remove the firmware loading error is just plain silly.
Jes
next prev parent reply other threads:[~2016-08-25 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <321381b3-5dea-f16a-56cb-11120d4a38ef@yandex.ru>
2016-08-25 11:23 ` rtl8192ce Lobachevskii Vitalii
2016-08-25 13:17 ` Jes Sorensen [this message]
2016-08-25 14:59 ` rtl8192ce Larry Finger
2016-08-25 15:13 ` rtl8192ce Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjmvk1asxp.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=silverunicorn2011@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.