All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Braun <michael-dev@fami-braun.de>,
	kvalo@codeaurora.org, akarwar@marvell.com, nishants@marvell.com,
	Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org,
	projekt-wlan@fem.tu-ilmenau.de
Subject: Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces
Date: Wed, 28 Sep 2016 13:22:28 -0400	[thread overview]
Message-ID: <wrfjoa38aqi3.fsf@redhat.com> (raw)
In-Reply-To: <1475077359.4139.44.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 28 Sep 2016 17:42:39 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2016-09-28 at 11:39 -0400, Jes Sorensen wrote:
>
>> > No Jes, you're wrong this time - this is changing internal API so
>> > it does have to touch all users thereof.
>> 
>> Even in this case, change the individual components in individual
>> patches and post them as a set.
>
> No, still wrong - it has to be committed as a single patch so it
> doesn't break bisect.
>
>> Changes to staging needs to go in via staging, and rtl8723au is gone
>> from the staging tree.
>> 
>
> I've previously taken API change patches that touch staging, if people
> feel so inclined, and I don't think Greg will mind. I'm going to keep
> doing that unless Dave tells me he won't pull from me when I do it :)

I'll still argue this could be handled better through gradual migration
rather than one large patch that touches too many places, but if you are
willing to take it, I am not going to fight you over it :)

Jes

  reply	other threads:[~2016-09-28 17:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 15:14 [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces Michael Braun
2016-09-28 15:19 ` Jes Sorensen
2016-09-28 15:32   ` Johannes Berg
2016-09-28 15:39     ` Jes Sorensen
2016-09-28 15:42       ` Johannes Berg
2016-09-28 17:22         ` Jes Sorensen [this message]
2016-09-28 22:10           ` Johannes Berg
2016-09-30 10:01 ` Johannes Berg
2016-10-03 10:44   ` Michael Braun
2016-10-04  8:29     ` Johannes Berg
2016-10-04  8:36       ` Johannes Berg
2016-10-04 21:12         ` M. Braun
2016-10-05  8:14           ` Johannes Berg
2016-10-04 21:57         ` M. Braun
2016-10-05  4:17           ` M. Braun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjoa38aqi3.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=akarwar@marvell.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michael-dev@fami-braun.de \
    --cc=nishants@marvell.com \
    --cc=projekt-wlan@fem.tu-ilmenau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.