From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH 00/16] rtl8xxxu prepare for splitting into multiple files
Date: Mon, 18 Apr 2016 12:07:14 -0400 [thread overview]
Message-ID: <wrfjoa96hpe5.fsf@redhat.com> (raw)
In-Reply-To: <1460995000.1917.5.camel@perches.com> (Joe Perches's message of "Mon, 18 Apr 2016 08:56:40 -0700")
Joe Perches <joe@perches.com> writes:
> On Mon, 2016-04-18 at 11:49 -0400, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Hi,
>>
>> This is the last set of patches I have in my queue for the rtl8xxxu
>> driver, as of today :)
>>
>> Since the driver has grown to support quite a number of different
>> chips, I want to split it into multiple files. This will make it
>> easier to maintain and also eaiser to add support for more chips
>> without having to constantly touch the core files.
>>
>> This set renames a bunch of functions to indicate that they are
>> generic rather than chip specific. I will look at doing the actual
>> moving around in a set right after the current merge window closes.
>
> It's a bit of a pity that the identifiers are all
> quite long. Using these long identifiers makes
> 80 column content a bit right shifted and single
> line statements unlikely.
Well I do agree that some of the names are long and I try to keep them
as short as possible when I can. However I refuse to turn this into a
NetBSD driver :)
Jes
next prev parent reply other threads:[~2016-04-18 16:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 15:49 [PATCH 00/16] rtl8xxxu prepare for splitting into multiple files Jes.Sorensen
2016-04-18 15:49 ` [PATCH 01/16] rtl8xxxu: Rename rtl8723bu_update_rate_mask() to rtl8xxxu_gen2_update_rate_mask() Jes.Sorensen
2016-04-26 9:27 ` [01/16] rtl8xxxu: Rename rtl8723bu_update_rate_mask() tortl8xxxu_gen2_update_rate_mask() Kalle Valo
2016-04-18 15:49 ` [PATCH 02/16] rtl8xxxu: Rename rtl8723bu_report_connect() to rtl8xxxu_gen2_report_connect() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 03/16] rtl8xxxu: Rename rtl8723au_report_connect() to rtl8xxxu_gen1_report_connect() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 04/16] rtl8xxxu: Rename rtl8723bu_config_channel() to rtl8xxxu_gen2_config_channel() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 05/16] rtl8xxxu: Rename rtl8723b_disable_rf() to rtl8xxxu_gen2_disable_rf() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 06/16] rtl8xxxu: Rename rtl8723a_disable_rf() to rtl8xxxu_gen1_disable_rf() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 07/16] rtl8xxxu: Rename rtl8723au_config_channel() to rtl8xxxu_gen1_config_channel() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 08/16] rtl8xxxu: Rename rtl8723au_update_rate_mask() to rtl8xxxu_update_rate_mask() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 09/16] rtl8xxxu: Rename rtl8723au_phy_iq_calibrate() to rtl8xxxu_gen1_phy_iq_calibrate() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 10/16] rtl8xxxu: Rename rtl8723au_init_phy_bb() to rtl8xxxu_gen1_init_phy_bb() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 11/16] rtl8xxxu: Rename rtl8723a_set_tx_power() to rtl8xxxu_gen1_set_tx_power() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 12/16] rtl8xxxu: Rename rtl8723a_enable_rf() to rtl8xxxu_gen1_enable_rf() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 13/16] rtl8xxxu: Rename rtl8723a_mac_init_table to rtl8xxxu_gen1_mac_init_table Jes.Sorensen
2016-04-18 15:49 ` [PATCH 14/16] rtl8xxxu: Rename rtl8723b_channel_to_group() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 15/16] rtl8xxxu: Rename rtl8723bu_simularity_compare() Jes.Sorensen
2016-04-18 15:49 ` [PATCH 16/16] rtl8xxxu: Rename rtl8723au_iqk_phy_iq_bb_reg Jes.Sorensen
2016-04-18 15:56 ` [PATCH 00/16] rtl8xxxu prepare for splitting into multiple files Joe Perches
2016-04-18 16:07 ` Jes Sorensen [this message]
2016-04-18 16:03 ` Larry Finger
2016-04-18 16:19 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjoa96hpe5.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.