From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] wireless: mac80211: Avoid using uninitialized stack data
Date: Fri, 12 Dec 2014 09:02:49 -0500 [thread overview]
Message-ID: <wrfjoar90xva.fsf@redhat.com> (raw)
In-Reply-To: <1418382219.2470.10.camel@sipsolutions.net> (Johannes Berg's message of "Fri, 12 Dec 2014 12:03:39 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2014-12-10 at 14:14 -0500, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Avoid case where we would access uninitialized stack data if a driver
>> advertises HT support without 40MHz channel support.
>
> I've fixed the commit message (it's actually in the check for the *AP*,
> not the driver!)
>
> Also, this is complicated. We originally had the DISABLE_VHT, but then
> found APs that were doing it wrong - see commit f3000e1b43f1 ("mac80211:
> fix broken use of VHT/20Mhz with some APs"). That fix introduced the bug
> here, going back now to the DISABLE_VHT as I'd suggested would break the
> fix again ... I'm thus taking this version to just put the right data on
> the stack, with the correct Fixes/Cc stable tags.
Either patch works for me, so I'm all good! Thanks for fixing this up!
Cheers,
Jes
next prev parent reply other threads:[~2014-12-12 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 19:14 [PATCH 0/1] mac80211: Avoid accessing uninitialized stack data Jes.Sorensen
2014-12-10 19:14 ` [PATCH 1/1] wireless: mac80211: Avoid using " Jes.Sorensen
2014-12-11 8:14 ` Johannes Berg
2014-12-12 11:03 ` Johannes Berg
2014-12-12 14:02 ` Jes Sorensen [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-11 16:37 [PATCH v2 0/1] mac80211: Avoid accessing " Jes.Sorensen
2014-12-11 16:37 ` [PATCH 1/1] wireless: mac80211: Avoid using " Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjoar90xva.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.