From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@linaro.org,
xie.baoyou@zte.com.cn
Subject: Re: fix:rtl8xxxu_core: mark symbols static where possible
Date: Sat, 03 Sep 2016 08:31:56 -0400 [thread overview]
Message-ID: <wrfjpool2mgz.fsf@redhat.com> (raw)
In-Reply-To: <20160903102822.84E496201B@smtp.codeaurora.org> (Kalle Valo's message of "Sat, 3 Sep 2016 10:28:22 +0000 (UTC)")
Kalle Valo <kvalo@codeaurora.org> writes:
> Baoyou Xie <baoyou.xie@linaro.org> wrote:
>> We get 1 warning about global functions without a declaration
>> in the rtl8xxxu rtl8xxxu_core.c when building with W=1:
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1:
>> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd'
>> [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
> The title should be "rtl8xxxu: ". See:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name
>
> Also I assume Jes will take this.
Yes to both accounts!
Thanks,
Jes
next parent reply other threads:[~2016-09-03 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160903102822.84E496201B@smtp.codeaurora.org>
2016-09-03 12:31 ` Jes Sorensen [this message]
2016-08-27 16:14 [PATCH] fix:rtl8xxxu_core: mark symbols static where possible Baoyou Xie
2016-09-03 10:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjpool2mgz.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.