All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation
Date: Fri, 23 Oct 2015 11:57:15 -0400	[thread overview]
Message-ID: <wrfjr3klefxg.fsf@redhat.com> (raw)
In-Reply-To: <1445448758-28794-1-git-send-email-luisbg@osg.samsung.com> (Luis de Bethencourt's message of "Wed, 21 Oct 2015 18:32:38 +0100")

Luis de Bethencourt <luisbg@osg.samsung.com> writes:
> For loop is outside of the else branch of the above conditional statement.
> Fixing misleading indentation.
>
> Fix a smatch warning:
> drivers/staging/rtl8723au/core/rtw_wlan_util.c:528
> WMMOnAssocRsp23a() warn: curly braces intended?
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> index 5e87360..cc2b84b 100644
> --- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> @@ -525,7 +525,7 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter)
>  	else
>  		aSifsTime = 16;
>  
> -		for (i = 0; i < 4; i++) {
> +	for (i = 0; i < 4; i++) {
>  		ACI = (pmlmeinfo->WMM_param.ac_param[i].ACI_AIFSN >> 5) & 0x03;
>  		ACM = (pmlmeinfo->WMM_param.ac_param[i].ACI_AIFSN >> 4) & 0x01;

      reply	other threads:[~2015-10-23 15:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 17:32 [PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation Luis de Bethencourt
2015-10-23 15:57 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjr3klefxg.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.